feat: Hook up UI components to websocket for chat#2081
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dankim214
changed the title
| queryKey: ['trollboxConnectedAddresses'], | ||
| queryFn: async (): Promise<number> => { | ||
| const response = await fetch(CONNECTED_ADDRESSES_URL); | ||
| if (!response.ok) throw new Error('Failed to fetch connected addresses'); |
There was a problem hiding this comment.
react-query will by default return the last stale response on Error which is probably what we want here (rather than defaulting to 0 or something)
…tocol/v4-web into dkim/hook-up-web-socket-trollbox
long text with no whitespace doesn't wrap |
| shape={ButtonShape.Square} | ||
| action={ButtonAction.Base} | ||
| state={{ isDisabled: isEmpty(inputValue.trim()) }} | ||
| state={{ isDisabled: isEmpty(inputValue.trim()) || isOverLimit }} |
There was a problem hiding this comment.
we should either keep this or the toast, if we disable the button the max char limit toast never shows
There was a problem hiding this comment.
possibly have validation + disabled state instead of waiting for handleSend?
There was a problem hiding this comment.
hmmm i think having both is still good imo
- the toast is to give an obvious response in the event the user hits enter to submit the message since they might not be looking at the send button
- the disabled button is to be able to quickly tell whether the message is still a valid size per keystroke (without having to try to hit enter to check)
There was a problem hiding this comment.
cool, I assumed the enter key wasn't working as well when the btn was disabled
3 participants
Screen.Recording.2026-02-18.at.4.55.58.PM.mov