Skip to content

feat: add custom_supported_browsers to update_passport_config() in ad… #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AaronAtDuo merged 4 commits into from
Mar 3, 2025
Merged

feat: add custom_supported_browsers to update_passport_config() in ad… #290

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a7d3d84
feat: add custom_supported_browsers to update_passport_config() in ad…
Feb 27, 2025
f8af04a
feat: add None as parameter defaults
Mar 3, 2025
3381aaa
add spaces where needed
Mar 3, 2025
c64d662
Replace '==' with 'is' for improved comparison consistency
Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion duo_client/admin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3677,7 +3677,7 @@ def get_passport_config(self):
response = self.json_api_call("GET", path, {})
return response

def update_passport_config(self, enabled_status, enabled_groups=[], disabled_groups=[]):
def update_passport_config(self, enabled_status, enabled_groups=[], disabled_groups=[], custom_supported_browsers={"macos": [], "windows": [],}):
Comment thread
AaronAtDuo marked this conversation as resolved.
Outdated
"""
Update the current Passport configuration.

Expand All @@ -3688,6 +3688,8 @@ def update_passport_config(self, enabled_status, enabled_groups=[], disabled_gro
list of user group IDs for whom Passport should be enabled
disabled_groups (list[str]) - if enabled_status is "enabled-with-exceptions",
a list of user group IDs for whom Passport should be disabled
custom_supported_browsers (dict) - a dict of criteria that determines whether
a Windows or macOS browsers should be supported by Passport
"""

path = "/admin/v2/passport/config"
Expand All @@ -3698,6 +3700,7 @@ def update_passport_config(self, enabled_status, enabled_groups=[], disabled_gro
"enabled_status": enabled_status,
"enabled_groups": enabled_groups,
"disabled_groups": disabled_groups,
"custom_supported_browsers": custom_supported_browsers,
},
)
return response
Expand Down
3 changes: 2 additions & 1 deletion tests/admin/test_passport.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,10 @@ def test_get_passport(self):
def test_update_passport(self):
""" Test update passport configuration
"""
response = self.client.update_passport_config(enabled_status="enabled-for-groups", enabled_groups=["passport-test-group"])
response = self.client.update_passport_config(enabled_status="enabled-for-groups", enabled_groups=["passport-test-group"], custom_supported_browsers={"macos": [{"team_id": "UBF8T346G9"},],"windows": [{"common_name": "Duo Security LLC"},],})
self.assertEqual(response["uri"], "/admin/v2/passport/config")
body = json.loads(response["body"])
self.assertEqual(body["enabled_status"], "enabled-for-groups")
self.assertEqual(body["enabled_groups"], ["passport-test-group"])
self.assertEqual(body["disabled_groups"], [])
self.assertEqual(body["custom_supported_browsers"], {"macos":[{"team_id":"UBF8T346G9"}],"windows":[{"common_name":"Duo Security LLC"}]})