Add new options_to_json_dict helper#256
Merged
MasterKale merged 4 commits intomasterfrom Jun 16, 2025
Merged
Conversation
Stormheg
added a commit
to Stormheg/django-otp-webauthn
that referenced
this pull request
Oct 4, 2025
Nice improvement in upstream api 👍 duo-labs/py_webauthn#256
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new
options_to_json_dicthelper that performs the same operation asoptions_to_jsonwithout stringifying thedictat the end. This can help Relying Parties combine the simplified representation options with other data before stringifying it all before sending it to the front end.options_to_jsonhas been refactored to calloptions_to_json_dictand stringify its return value, to preserve its existing functionality.Fixes #254.