feat(solana): add GoonFi v2 DEX integration#9257
feat(solana): add GoonFi v2 DEX integration#9257eekey-cloud wants to merge 1 commit intoduneanalytics:mainfrom
Conversation
Add GoonFi v2 DEX spellbook integration for Solana with: - Staging table for raw swaps - Base trades model - Trades view - Updated schema with v2 models Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
PR SummaryMedium Risk Overview Wires GoonFi v2 into the unified Written by Cursor Bugbot for commit fac2b89. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Comment @cursor review or bugbot run to trigger another review on this PR
| AND tf.inner_instruction_index IN (s.inner_instruction_index + 1, s.inner_instruction_index + 2) | ||
| WHERE tf.token_version IN ('spl_token', 'spl_token_2022') | ||
| {% if is_incremental() -%} | ||
| AND {{ incremental_predicate('tf.block_date') }} |
There was a problem hiding this comment.
Inconsistent incremental predicates mixing block_time and block_date
Low Severity
The goonfi_v2_solana_base_trades.sql model inconsistently mixes block_time and block_date for incremental predicates. The config (line 9) and swaps CTE (line 34) use block_time, while the transfers filter (line 68) uses block_date. This differs from the v1 goonfi model and the aquifer model, which consistently use block_date throughout. The inconsistency makes the code harder to maintain and could lead to subtle data synchronization issues around date boundaries.
|
Closing PR |
Summary
Test plan