Skip to content

1inch-U88: ar stream updates#9251

Merged
jeff-dude merged 5 commits intoduneanalytics:mainfrom
max-morrow:1inch-updates-88
Feb 18, 2026
Merged

1inch-U88: ar stream updates#9251
jeff-dude merged 5 commits intoduneanalytics:mainfrom
max-morrow:1inch-updates-88

Conversation

@max-morrow
Copy link
Copy Markdown
Contributor

@max-morrow max-morrow commented Jan 29, 2026

added calculations of useful input data for AggregationRouterV6

easy dates success run

@github-actions github-actions Bot added WIP work in progress dbt: dex covers the DEX dbt subproject labels Jan 29, 2026
@max-morrow max-morrow changed the title 1inch-U88 1inch-U88: ar stream updates Jan 29, 2026
@max-morrow max-morrow marked this pull request as ready for review January 29, 2026 19:57
Copilot AI review requested due to automatic review settings January 29, 2026 19:57
@cursor
Copy link
Copy Markdown

cursor Bot commented Jan 29, 2026

PR Summary

Medium Risk
Changes how call_input_remains and remains are derived for AggregationRouterV6 calls, which can alter decoded output fields and downstream models; risk is moderate due to protocol-specific parsing assumptions.

Overview
Adds a per-method useful byte-length config for AggregationRouterV6 methods and threads it through oneinch_ar_macro to compute call_input_remains based on the meaningful portion of call_input (instead of relying solely on ABI padding).

Also updates remains extraction to drop zero 4-byte words, reducing noise in the parsed remainder data.

Written by Cursor Bugbot for commit 8946557. Configure here.

@github-actions github-actions Bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Jan 29, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds calculations for useful input data in the 1inch AggregationRouterV6 by introducing a new useful field to track the offset where meaningful call input data ends, and updating the remains calculation to filter out zero values.

Changes:

  • Added useful field to method configurations to precisely calculate the end of useful input data
  • Modified call_input_remains calculation to use the new useful field as the primary offset
  • Updated remains array processing to filter out zero values

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
oneinch_ar_macro.sql Adds useful field extraction, updates call_input_remains calculation to use it, and filters zeros from remains array
oneinch_ar_contracts_cfg_macro.sql Defines useful offset values for each AggregationRouterV6 method based on parameter count

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jeff-dude jeff-dude self-assigned this Feb 17, 2026
@jeff-dude jeff-dude added ready-for-merging and removed ready-for-review this PR development is complete, please review labels Feb 17, 2026
@jeff-dude jeff-dude merged commit 5276110 into duneanalytics:main Feb 18, 2026
5 of 6 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dbt: dex covers the DEX dbt subproject ready-for-merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants