Skip to content

fix(security): stop logging the package link (it contains the UPN key) #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Androz2091 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(security): stop logging the package link (it contains the UPN key) #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -919,7 +919,10 @@ def process_package(package_status_id, package_id, link, worker_name='regular_pr
worker Lambda in production. worker_name lets premium-only work skip the
regular-process path; we only run regular_process today.
"""
print(f'handling package {package_id} with link {link}')
# Don't log the link itself: it ends with ?upn=<UPN>, which is the
# AES key for that user's encrypted blob. Logging it would put the
# decryption key in CloudWatch.
print(f'handling package {package_id}')
session = Session()
package_status = session.query(PackageProcessStatus).filter(PackageProcessStatus.id == package_status_id).first()
if not package_status:
Expand Down