Add svgo to devDependencies and avoid removing viewBox#166
Open
dcroote wants to merge 1 commit intoduerrsimon:mainfrom
Open
Add svgo to devDependencies and avoid removing viewBox#166dcroote wants to merge 1 commit intoduerrsimon:mainfrom
dcroote wants to merge 1 commit intoduerrsimon:mainfrom
Conversation
Owner
|
Thanks for the pull request. I am against merging it now since it just adds the dev dependency and I don't think many submitters actually clone the repo. |
Contributor
Author
|
I guess I don't know how your current or proposed processing pipeline is/will be implemented, but having svgo as a devDependency (along with the config file that prevents removal of the viewBox) would open up options to use it within a GitHub Actions workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought this would help per the instructions in CONTRIBUTING.md. Note I didn't add
svgo-viewboxbecause whenever I used it with an Inkscape image it would botch the size / viewBox. Instead, addingremoveViewBox: falseas an override ofsvgovia thesvgo.config.mjsfile (long complaint thread here) appears to work well.