Fix: unknown type variant - #86
Open
aersam wants to merge 1 commit into
Open
Conversation
Without this mapping, any table with a variant column raises: NotImplementedException: Tried to fallback to unknown type for 'variant' Fixes duckdb#83 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Author
|
Not very surpring, this is AI-generated, and I must admin I did not execute tests locally. I'm really not in C++, but the code looks simple, so it's worth a try :) |
|
Any updates on this PR getting reviewed? I'm experiencing this issue as well. Would be happy to test it in nightly if a maintainer reviewed and merged this 🙂 |
|
@benfleis Hi, could you review this PR? DuckDB supports the VARIANT type, |
getChan
approved these changes
Jul 31, 2026
Member
|
On it, I have some tweaks to add, will come back with review or push an update myself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When querying tables that have a
variantcolumn, the following error is raised:The fix maps
variantto DuckDB'sLogicalType::VARIANT().Fixes #83
Related to #82 (same pattern, for
timestamp_ntz).Test plan
scripts/databricks_data_gen/custom_data_sources/variant_table.sqlto generate a test table with a variant column on Databrickstest/sql/databricks/variant.testto verify reading such a table works end-to-end🤖 Generated with Claude Code