Map unsupported fsspec mtimes to NotImplementedException. - #588
Open
agrawal-priyank wants to merge 1 commit into
Open
Map unsupported fsspec mtimes to NotImplementedException.#588agrawal-priyank wants to merge 1 commit into
agrawal-priyank wants to merge 1 commit into
Conversation
DuckDB already turns NOT_IMPLEMENTED last-modified lookups into NULL; the Python adapter was leaking untyped exceptions (including gcsfs KeyError('mtime')), which aborted callers such as DuckLake CHECKPOINT.
agrawal-priyank
force-pushed
the
fix/fsspec-last-modified-not-implemented
branch
from
August 16, 2026 17:26
169ffe2 to
62fc5e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NotImplementedErrorand gcsfsKeyError('mtime')inPythonFilesystem::GetLastModifiedTime()into DuckDBNotImplementedException, soread_blob(...).last_modifiedis NULL instead of an untyped query failure.Fixes #584
Test plan
uv run pytest tests/fast/api/test_fsspec.py -vuv run pytest tests/fast/test_filesystem.py -v