fix: register CTE schema correctly when params rename columns#21
Merged
fix: register CTE schema correctly when params rename columns#21
Conversation
When a CTE uses params to rename columns, the schema now reflects the renamed column names instead of passing through the original names. This prevents silent failures in downstream column lookups. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add a post-construction length check to catch duplicate param names that would collapse into fewer columns (both case-sensitive and case-insensitive). Also strengthen tests with value assertions and duplicate detection cases. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Split the guard clause so params on a schema-less source raises QueryBuilderError instead of silently discarding them. Also pin the params=[] passthrough behavior with a test. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cte.schemato reflect renamed column names whenparamsare provided, instead of passing through the original source column namesQueryBuilderErrorCloses #9
Test plan
test_cte_schema: non-parameterized CTE passes through source schema unchangedtest_cte_schema: parameterized CTE reflects renamed columns with correct typestest_cte_schema: param count mismatch raisesQueryBuilderErrortest_cte_schema: schema type (case sensitivity) is preservedtest_query.pypass🤖 Generated with Claude Code