Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions core/src/main/java/com/dropbox/core/DbxOAuth1Upgrader.java
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
import com.fasterxml.jackson.core.JsonToken;

import java.io.IOException;
import java.io.UnsupportedEncodingException;
import java.net.URLEncoder;
import java.nio.charset.StandardCharsets;
import java.util.ArrayList;

/**
Expand Down Expand Up @@ -105,7 +105,14 @@ private String buildOAuth1Header(DbxOAuth1AccessToken token)

private static String encode(String s)
{
return URLEncoder.encode(s, StandardCharsets.UTF_8);
try {
// Use the String overload for Android API compatibility. The Charset overload was
// added to Android much later than the String overload.
return URLEncoder.encode(s, "UTF-8");
} catch (UnsupportedEncodingException ex) {
// UTF-8 is required by every Java implementation.
throw new AssertionError(ex);
}
}

/**
Expand Down
11 changes: 9 additions & 2 deletions core/src/main/java/com/dropbox/core/DbxRequestUtil.java
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
package com.dropbox.core;

import java.io.IOException;
import java.io.UnsupportedEncodingException;
import java.net.URI;
import java.net.URISyntaxException;
import java.net.URLEncoder;
import java.nio.charset.CharacterCodingException;
import java.nio.charset.StandardCharsets;
import java.util.concurrent.TimeUnit;
import java.util.ArrayList;
import java.util.List;
Expand Down Expand Up @@ -38,7 +38,14 @@ public final class DbxRequestUtil {
public static DbxGlobalCallbackFactory sharedCallbackFactory;

public static String encodeUrlParam(String s) {
return URLEncoder.encode(s, StandardCharsets.UTF_8);
try {
// Use the String overload for Android API compatibility. The Charset overload was
// added to Android much later than the String overload.
return URLEncoder.encode(s, "UTF-8");
} catch (UnsupportedEncodingException ex) {
// UTF-8 is required by every Java implementation.
throw new AssertionError(ex);
}
}

public static String buildUrlWithParams(/*@Nullable*/String userLocale,
Expand Down
14 changes: 14 additions & 0 deletions core/src/test/java/com/dropbox/core/DbxRequestUtilTest.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
package com.dropbox.core;

import static com.google.common.truth.Truth.assertThat;

import org.testng.annotations.Test;

public class DbxRequestUtilTest {

@Test
public void testEncodeUrlParam() {
assertThat(DbxRequestUtil.encodeUrlParam("hello world/+"))
.isEqualTo("hello+world%2F%2B");
}
}
Loading