Add support for ECR Public registry#357
Add support for ECR Public registry#357tlinhart wants to merge 1 commit intodrone-plugins:masterfrom
Conversation
|
Hi @tlinhart thanks for the PR, to start with. |
|
Hi @tphoney, this PR doesn't add support for pushing the drone-docker image itself to ECR. It adds support for building and pushing images to ECR Public registry in the pipeline step. Just like for other already supported registries (ECR, GCR etc.) The main reason for this PR is that Loki repository (by Grafana) uses Drone and ECR Public as the target registry for their Promtail Lambda tool. I opened a PR for adding ARM64 support (grafana/loki#5354) but there was a problem in that there was no ARM64 runner image (i.e. drone-docker plugin) for the ECR Public. So I thought it would be a generally good idea to add the support for another possibly widely used registry to the upstream. |
|
I too need to push images to public ECR -- this caught me a bit off guard since kaniko plugins were able to without particular config and I did a lot of trial and errors before landing here. |
|
We are also looking into pushing into the public ECR registry ... |
Adds support for the ECR Public registry. There is a fork (https://github.com/cstyan/drone-docker) which can already be used for the purpose. However, it produces Docker image only for x86-64 architecture and it might be a good idea to have it under one roof with other registries.