Open
Conversation
Something not working @l58
Workaround for Kotlin. It gets the first char of a class (first index);
it checks if before the class name there's another char, if true skip
this line; calculates the used lenght, adding to the first index, the
length of class name, plus a special char (like . ( ). At the end it
checks if the substring matches with a valid usage of class name, so
replace it with the URL.
PROS: it works.
CONS: if exists a string with " Main(", the workaround detects it like a
code line.
Owner
|
Till we are not sure that it isn't breaking anything let's not merge this in. I'd rather not provide support for something than to add error prone code in production. I like your Settings page though, if you'd like to send that as a PR. Also, please make sure you squash your commits, as it helps keep the git history clean and reviews are much more easier. |
DVDAndroid
force-pushed
the
kotlin-support
branch
from
90d1622 to
ff1788d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.