[Pg-kit]: Fix functional index generation in pull#5242
Open
backend-hyoseok wants to merge 1 commit intodrizzle-team:betafrom
Open
[Pg-kit]: Fix functional index generation in pull#5242backend-hyoseok wants to merge 1 commit intodrizzle-team:betafrom
backend-hyoseok wants to merge 1 commit intodrizzle-team:betafrom
Conversation
Fixed a bug where `drizzle-kit pull` generated incorrect TypeScript for functional/computed indexes. The generator was incorrectly using the boolean `isExpression` property instead of the `value` property when creating the `sql` template literal, resulting in `sql`true`` in the output. Fixes drizzle-team#5224
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug where
drizzle-kit pullgenerated incorrect TypeScript file for functional/computed indexes. The generator was incorrectly using the booleanisExpressionproperty instead of thevalueproperty when creating thesqltemplate literal, resulting insqltrue`` in the output.Fixes #5224