[#3012] Migrated release drafter's default version resolver to a 'version-resolver' category. - #3013
Conversation
…sion-resolver' category.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
WalkthroughThe release configuration replaces the global ChangesRelease Drafter configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized configuration migration removes a deprecation warning while preserving the existing version fallback and explicit workflow inputs; no actionable merge-blocking risk remains beyond normal checks. Possibly related issues
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Code coverage (threshold: 90%) Per-class coverage |
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
|
Code coverage (threshold: 90%) Per-class coverage |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3013 +/- ##
==========================================
- Coverage 87.11% 86.70% -0.42%
==========================================
Files 101 94 -7
Lines 4912 4753 -159
Branches 47 3 -44
==========================================
- Hits 4279 4121 -158
+ Misses 633 632 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
📖 Documentation preview for this pull request has been deployed to Netlify: https://6a7eb49be8ab451914c8e62e--vortex-docs.netlify.app This preview is rebuilt on every commit and is not the production documentation site. |
Closes #3012
Summary
Release Drafter v7.7.0 (pinned at
34d80673e067bdc0c24568d3af899c216adcfaa9in.github/workflows/draft-release-notes.yml) deprecated the top-levelversion-resolverblock, so everyDraft release notesrun logged a warning asking maintainers to migrateversion-resolver.defaultinto acategoriesentry. This PR migrates.github/release-drafter.ymlto the new shape, and regenerates the installer's baseline fixture that mirrors this file.Changes
version-resolver: default: minorblock in.github/release-drafter.ymlwith acategoriesentry oftype: 'version-resolver'andsemver-increment: 'minor'. Verified against the pinned action source:src/actions/drafter/config/parse-categories.tstranslates the legacyversion-resolver.defaultkey into exactly this shape ({ type: 'version-resolver', 'semver-increment': <default>, when: [], exclusive: false }) at parse time, andwhen/exclusiveare omitted here since they match their defaults ([]andfalse), so the new config is the exact semantic equivalent, not an approximation.version-resolver.defaultis present alongside an empty-whenversion-resolvercategory - so the legacy block was removed rather than left alongside the new one.type: changelogcategories produce sections, so theversion-resolvercategory adds no heading to the generated release notes.minordefault is preserved as-is; it matters for consumers on thesemverrelease scheme, wheredraft-release-notes.ymlpasses no explicit version andresolve-version-increment.tsuses this category as the fallback bump (on the defaultcalverscheme the workflow passes an explicit version instead)..vortex/installer/tests/Fixtures/handler_process/_baseline/.github/release-drafter.ymlviaahoy update-snapshotsso the installer's baseline fixture matches the new config shape.Before / After
Summary by CodeRabbit