Skip to content

[#3012] Migrated release drafter's default version resolver to a 'version-resolver' category. - #3013

Merged
AlexSkrypnyk merged 2 commits into
mainfrom
feature/3012-release-drafter
Aug 14, 2026
Merged

[#3012] Migrated release drafter's default version resolver to a 'version-resolver' category.#3013
AlexSkrypnyk merged 2 commits into
mainfrom
feature/3012-release-drafter

Conversation

@AlexSkrypnyk

@AlexSkrypnyk AlexSkrypnyk commented Aug 14, 2026

Copy link
Copy Markdown
Member

Closes #3012

Summary

Release Drafter v7.7.0 (pinned at 34d80673e067bdc0c24568d3af899c216adcfaa9 in .github/workflows/draft-release-notes.yml) deprecated the top-level version-resolver block, so every Draft release notes run logged a warning asking maintainers to migrate version-resolver.default into a categories entry. This PR migrates .github/release-drafter.yml to the new shape, and regenerates the installer's baseline fixture that mirrors this file.

Changes

  • Replaced the deprecated version-resolver: default: minor block in .github/release-drafter.yml with a categories entry of type: 'version-resolver' and semver-increment: 'minor'. Verified against the pinned action source: src/actions/drafter/config/parse-categories.ts translates the legacy version-resolver.default key into exactly this shape ({ type: 'version-resolver', 'semver-increment': <default>, when: [], exclusive: false }) at parse time, and when/exclusive are omitted here since they match their defaults ([] and false), so the new config is the exact semantic equivalent, not an approximation.
  • The two forms cannot coexist - the parser throws if version-resolver.default is present alongside an empty-when version-resolver category - so the legacy block was removed rather than left alongside the new one.
  • Changelog rendering is unaffected: only type: changelog categories produce sections, so the version-resolver category adds no heading to the generated release notes.
  • The minor default is preserved as-is; it matters for consumers on the semver release scheme, where draft-release-notes.yml passes no explicit version and resolve-version-increment.ts uses this category as the fallback bump (on the default calver scheme the workflow passes an explicit version instead).
  • Single-quoted the new scalar values to match the file's existing style, where every other scalar is single-quoted.
  • Regenerated .vortex/installer/tests/Fixtures/handler_process/_baseline/.github/release-drafter.yml via ahoy update-snapshots so the installer's baseline fixture matches the new config shape.
  • Upstream migration reference: feat: unify category config around change classification release-drafter/release-drafter#1558

Before / After

BEFORE - legacy top-level key, deprecated in v7.7.0

┌──────────────────────────────────────────────────┐
│ version-resolver:                                │
│   default: minor                                 │
└────────────────────────┬─────────────────────────┘
                         │ parse-categories.ts translates it at runtime
                         ▼
┌──────────────────────────────────────────────────┐
│ { type: 'version-resolver',                      │
│   semver-increment: 'minor',                     │
│   when: [], exclusive: false }                   │
└────────────────────────┬─────────────────────────┘
                         │
                         ▼
         resolve-version-increment.ts: fallback bump = minor
                         │
                         ▼
         deprecation warning on every release-notes run


AFTER - explicit category, current shape

┌──────────────────────────────────────────────────┐
│ categories:                                      │
│   - type: 'version-resolver'                     │
│     semver-increment: 'minor'                    │
└────────────────────────┬─────────────────────────┘
                         │ read directly, no translation step
                         ▼
         resolve-version-increment.ts: fallback bump = minor
                         │
                         ▼
         no warning, identical resolution outcome

Summary by CodeRabbit

  • Chores
    • Updated release versioning rules so changes categorized under the designated release category trigger a minor version increment.

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 829d25ab-1baa-4873-af57-4c379f69ad62

📥 Commits

Reviewing files that changed from the base of the PR and between c0c2aaa and 6001f12.

⛔ Files ignored due to path filters (1)
  • .vortex/installer/tests/Fixtures/handler_process/_baseline/.github/release-drafter.yml is excluded by !.vortex/installer/tests/Fixtures/**
📒 Files selected for processing (1)
  • .github/release-drafter.yml

Walkthrough

The release configuration replaces the global version-resolver default with a categorized rule that assigns a minor semantic-version increment.

Changes

Release Drafter configuration

Layer / File(s) Summary
Categorized version resolution
.github/release-drafter.yml
The configuration assigns a minor semantic-version increment to the version-resolver category instead of using a global default.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 6001f

This localized configuration migration removes a deprecation warning while preserving the existing version fallback and explicit workflow inputs; no actionable merge-blocking risk remains beyond normal checks.

Possibly related issues

  • drevops/vortex#3012 — Both changes replace the deprecated version-resolver.default setting with a categorized minor version rule.

Poem

A rabbit checks the release chart,
“Minor steps now guide the start.”
The drafter sorts each change in line,
And marks the next release as fine.
Hop, hop, versions grow—
Cleanly through the workflow they go!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: migrating Release Drafter's default version resolver to a version-resolver category.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/3012-release-drafter

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Code coverage (threshold: 90%)

  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   98.56% (206/209)
Per-class coverage
Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

@AlexSkrypnyk

This comment has been minimized.

2 similar comments
@AlexSkrypnyk

This comment has been minimized.

@AlexSkrypnyk

Copy link
Copy Markdown
Member Author

Code coverage (threshold: 90%)

  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   98.56% (206/209)
Per-class coverage
Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.70%. Comparing base (c0c2aaa) to head (6001f12).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3013      +/-   ##
==========================================
- Coverage   87.11%   86.70%   -0.42%     
==========================================
  Files         101       94       -7     
  Lines        4912     4753     -159     
  Branches       47        3      -44     
==========================================
- Hits         4279     4121     -158     
+ Misses        633      632       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown

📖 Documentation preview for this pull request has been deployed to Netlify:

https://6a7eb49be8ab451914c8e62e--vortex-docs.netlify.app

This preview is rebuilt on every commit and is not the production documentation site.

@AlexSkrypnyk AlexSkrypnyk added the Needs review Pull request needs a review from assigned developers label Aug 14, 2026
@AlexSkrypnyk
AlexSkrypnyk merged commit 90a02b3 into main Aug 14, 2026
36 checks passed
@AlexSkrypnyk
AlexSkrypnyk deleted the feature/3012-release-drafter branch August 14, 2026 07:03
@github-project-automation github-project-automation Bot moved this from BACKLOG to Release queue in Vortex 1.x Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A1 Board worker 1 Needs review Pull request needs a review from assigned developers

Projects

Status: Release queue

Development

Successfully merging this pull request may close these issues.

Update release drafter config

1 participant