Vue 3 Migration — Phase 2: Simple Read-Only Pages#1038
Merged
Conversation
- stores/help.ts: Pinia port of Vuex help module with manifest loading, document cache, and Fuse.js full-text search - components/MarkdownRenderer.vue: async marked v18 API via watch+ref; :deep() CSS selectors; import.meta.env.BASE_URL for portable help links across base paths - views/HomeView.vue: reads systemStore.currentShow/settings + userStore.currentUser; currentShowSession stubbed null until Phase 6 - views/AboutView.vue: static content port - views/HelpView.vue: BVN port with sticky sidebar, debounced search, dynamic navbar height offset - views/help/HelpDocView.vue: cache-first doc loading, watch route.params.slug - router: wire /about and /help routes; fix /help child redirect to absolute path; fix catch-all to render NotFoundView in-place (no URL redirect) matching Vue 2 behaviour Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stores/help.ts— Pinia port of the Vuex help module: manifest loading, per-slug document cache, and Fuse.js full-text searchcomponents/MarkdownRenderer.vue— Port withmarkedv18 async API (watch+refinstead ofcomputed);>>>deep selectors replaced with:deep();import.meta.env.BASE_URLused for help links so they work at both/ui-new/and/(Phase 14 cutover)views/HomeView.vue— ReadssystemStore.currentShow/settings+userStore.currentUser;currentShowSessionstubbed asnulluntil Phase 6 wires in the show storeviews/AboutView.vue— Static content,<script setup>views/HelpView.vue— BVN port with sticky sidebar nav, debounced Fuse.js search, dynamic navbar height offsetviews/help/HelpDocView.vue— Cache-first document loading, watchesroute.params.slugrouter/index.ts— Wire/aboutand/help//help/:slugto real components; fix/helpchild empty-path redirect to use absolute path/help/getting-started; fix catch-all to renderNotFoundViewin-place (no URL redirect), matching Vue 2path: '*'behaviourTest plan
npm run buildpassesnpm run typecheckpassesnpm run ci-lintpasses/ui-new/— HomeView shows current show name and session state/ui-new/about— matches Vue 2/aboutvisually/ui-new/help— redirects to/ui-new/help/getting-started, sidebar and markdown render correctly/ui-new/some/unknown— shows 404 page without changing URL🤖 Generated with Claude Code