Use Promise.all()

[imaman]

Initial motivation for this PR was https://npmjs.com/advisories/781 .

This security issue can also be solved by other means (the two PRs opened on node.flow: dreamerslab/node.flow#4, dreamerslab/node.flow#5), I believe that migrating the code in here to using Promises is a course of action which will benefit the long term maintainability of this repo (as Promises are the de-facto standard for managing async computations).

In this PR I tried to be as conservative as possible: I just made the minimal change that could work. If you feel that it is OK for this code to use newer constructs (async/await, arrow functions) please let me know. I'd be happy to do this porting as well.

$ npm audit
                                                                                
                       === npm audit security report ===                        
                                                                                
┌──────────────────────────────────────────────────────────────────────────────┐
│                                Manual Review                                 │
│            Some vulnerabilities require your attention to resolve            │
│                                                                              │
│         Visit https://go.npm.me/audit-guide for additional guidance          │
└──────────────────────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ Moderate      │ Prototype Pollution                                          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ node.extend                                                  │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=1.1.7 <2.0.0 || >= 2.0.1                                   │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ node.flow                                                    │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ node.flow > node.extend                                      │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://npmjs.com/advisories/781                             │
└───────────────┴──────────────────────────────────────────────────────────────┘

[nullivex]

I hope that one of these get accepted. Or the repository ownership should be transferred.

@imaman Good work!

[nullivex]

I didnt see any movement here so went ahead and forked this and applied the PR.

See this release:
https://github.com/nullivex/rmdir2

https://www.npmjs.com/package/rmdir2

[nullivex]

I tested this release working great for me.