fix: update default proxmox node name from "pve" to "proxmox"#286
Merged
mkultraWasHere merged 3 commits intoJun 29, 2026
Conversation
**Key Changes:** - Updated the default Proxmox node name to "proxmox" in both the CLI provider logic and the Terraform variable template - Ensures consistent default node naming across the codebase **Changed:** - Default Proxmox node name - Updated fallback value from `"pve"` to `"proxmox"` in the CLI provider initialization (`cli/internal/proxmox/provider.go`) and the Terraform variables template (`template/provider/proxmox/variables.tf`) to align defaults across both layers
Contributor
Author
|
@mkultraWasHere - this should pass once #288 is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Changes:
Changed:
"pve"to"proxmox"in the CLI provider initialization (cli/internal/proxmox/provider.go) and aligned the Terraform variable template default value intemplate/provider/proxmox/variables.tfto match