Support postfixed release tags - #76
Open
kjanat wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support repositories that namespace formatter releases with a tag suffix while retaining the formatter’s bare version in
latest.json.For kjanat/PSScriptAnalyzer, a release tagged 0.1.1-dprint is reported as formatter version 0.1.1, while the plugin and schema URLs resolve assets from that exact GitHub release. I want to keep my fork's tags separate from upstream PowerShell/PSScriptAnalyzer, that does not create/expose a separate wasm formatter for powershell files, by adding a suffix to the tags.
Validation:
npm exec vitest -- run plugins.test.ts -t 'tryResolveAssetUrl|resolves a postfixed dprint release tag|resolves a schema from a postfixed dprint release tag'npm exec tsc -- --noEmitdprint check plugins.ts plugins.test.ts