Skip to content

Also wait_for_topics on <0.10 test fixtures #3105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpkp merged 2 commits into from
Jun 24, 2026
+20 −12
Merged

Also wait_for_topics on <0.10 test fixtures #3105

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d03219
Also wait_for_topics on <0.10 test fixtures
dpkp Jun 24, 2026
ebe722a
pass api_version to create_topics admin client
dpkp Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 20 additions & 12 deletions test/integration/fixtures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,21 +34,29 @@ def create_topics(broker, topic_names, num_partitions=None, replication_factor=N
for topic_name in topic_names:
# TODO: verify kafka-topics.sh support for early 0.8 brokers
broker._create_topic_via_cli(topic_name, num_partitions, replication_factor)
_wait_for_topics(broker, topic_names)


def _create_topics_via_admin(broker, topic_names, num_partitions, replication_factor):
from kafka.admin import NewTopic
params = broker._enrich_client_params({}, client_id='topic_creator')
admin = KafkaAdminClient(**params)
try:
topics = [NewTopic(name, num_partitions, replication_factor) for name in topic_names]
admin.create_topics(topics, wait_for_metadata=True)
except InvalidReplicationFactorError:
time.sleep(0.5)
topics = [NewTopic(name, num_partitions, replication_factor) for name in topic_names]
admin.create_topics(topics, wait_for_metadata=True)
finally:
admin.close()
params = broker._enrich_client_params({'api_version': env_kafka_version(), 'client_id': 'topic_creator'})
with KafkaAdminClient(**params) as admin:
try:
topics = {name: {'num_partitions': num_partitions, 'replication_factor': replication_factor}
for name in topic_names}
admin.create_topics(topics, wait_for_metadata=True)
except InvalidReplicationFactorError:
# wait and try again
# in CI the brokers sometimes take a while to find themselves
time.sleep(0.5)
topics = {name: {'num_partitions': num_partitions, 'replication_factor': replication_factor}
for name in topic_names}
admin.create_topics(topics, wait_for_metadata=True)


def _wait_for_topics(broker, topics):
params = broker._enrich_client_params({'api_version': env_kafka_version(), 'client_id': 'topic_creator'})
with KafkaAdminClient(**params) as admin:
admin.wait_for_topics(topics)


def client_params(broker, client_id='client', **overrides):
Expand Down