Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kafka/protocol/new/schemas/fields/simple.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def _calculate_default(self, default):
return int(default)
elif self._type is UUID:
if not default:
return UUID.ZERO_UUID
return None
else:
return uuid.UUID(default)
elif self._type is Float64:
Expand Down
7 changes: 6 additions & 1 deletion kafka/protocol/types.py
Original file line number Diff line number Diff line change
Expand Up @@ -102,13 +102,18 @@ class UUID(AbstractType):

@classmethod
def encode(cls, value):
if value is None:
value = cls.ZERO_UUID
if isinstance(value, uuid.UUID):
return value.bytes
return uuid.UUID(value).bytes

@classmethod
def decode(cls, data):
return uuid.UUID(bytes=data.read(16))
val = uuid.UUID(bytes=data.read(16))
if val == cls.ZERO_UUID:
return None
return val


class String(AbstractType):
Expand Down
2 changes: 1 addition & 1 deletion test/protocol/new/admin/test_new_admin.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def test_create_topics_response_roundtrip(version):
topics=[
Topic(
name="test-topic",
topic_id=uuid.uuid4() if version >= 7 else uuid.UUID(int=0),
topic_id=uuid.uuid4() if version >= 7 else None,
error_code=13,
error_message='foo' if version >= 1 else '',
topic_config_error_code=2 if version >= 5 else 0,
Expand Down
Loading