Skip to content

Add DEFAULT_GENERATION_ID and UNKNOWN_MEMBER_ID to kafka.protocol.new #2742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpkp merged 1 commit into from
Mar 19, 2026
+13 −0
Merged

Add DEFAULT_GENERATION_ID and UNKNOWN_MEMBER_ID to kafka.protocol.new #2742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions kafka/protocol/new/consumer/group.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
from ..api_message import ApiMessage


DEFAULT_GENERATION_ID = -1
UNKNOWN_MEMBER_ID = ''

class JoinGroupRequest(ApiMessage): pass
class JoinGroupResponse(ApiMessage): pass

Expand All @@ -21,6 +24,7 @@ class OffsetCommitResponse(ApiMessage): pass


__all__ = [
'DEFAULT_GENERATION_ID', 'UNKNOWN_MEMBER_ID',
'JoinGroupRequest', 'JoinGroupResponse',
'SyncGroupRequest', 'SyncGroupResponse',
'LeaveGroupRequest', 'LeaveGroupResponse',
Expand Down
9 changes: 9 additions & 0 deletions test/protocol/new/consumer/test_new_group.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

from kafka.protocol.new.metadata import FindCoordinatorRequest, FindCoordinatorResponse
from kafka.protocol.new.consumer import (
DEFAULT_GENERATION_ID, UNKNOWN_MEMBER_ID,
JoinGroupRequest, JoinGroupResponse,
SyncGroupRequest, SyncGroupResponse,
LeaveGroupRequest, LeaveGroupResponse,
Expand Down Expand Up @@ -331,3 +332,11 @@ def test_offset_commit_response_roundtrip(version):
encoded = OffsetCommitResponse.encode(data, version=version)
decoded = OffsetCommitResponse.decode(encoded, version=version)
assert decoded == data


def test_default_generation_id():
assert DEFAULT_GENERATION_ID == -1


def test_unknown_member_id():
assert UNKNOWN_MEMBER_ID == ''
Loading