Store in-flight request headers only for protocol parser#2723
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
kafka/protocol/parser.py
Dismissed
| response_type = get_response_class(header.api_key, header.api_version) | ||
| if response_type is None: | ||
| log.error('Unable to find ResponseType for api_key=%d api_version=%d', | ||
| header.api_key, header.api_version) |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
Copilot Autofix
AI 17 days ago
Copilot could not generate an autofix suggestion
Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.
Owner
Author
There was a problem hiding this comment.
false positive. api_key is not sensitive.
dpkp
force-pushed
the
dpkp/get-response-class
branch
2 times, most recently
from
50d0aa7 to
afa3b96
Compare
dpkp
force-pushed
the
dpkp/get-response-class
branch
from
7ee4a67 to
1ebc1fd
Compare
dpkp
force-pushed
the
master
branch
2 times, most recently
from
d4637e5 to
efbcb43
Compare
dpkp
force-pushed
the
dpkp/get-response-class
branch
from
1ebc1fd to
ce4c150
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No longer need to track RESPONSE_TYPE explicitly on each request class. Currently creates a greedy class registry on kafka.protocol import; will leave lazy registry for later if needed.
Also refactor common methods from kafka.protocol.api.Request and Response in to a common RequestResponse class. Adds stateful header property.