Skip to content

Fix zstd multi-frame decompression failure (#2716) #2717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpkp merged 1 commit into from
Feb 25, 2026
Merged

Fix zstd multi-frame decompression failure (#2716) #2717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions kafka/codec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,5 @@ def zstd_encode(payload):
def zstd_decode(payload):
if not zstd:
raise NotImplementedError("Zstd codec is not available")
try:
return zstd.ZstdDecompressor().decompress(payload)
except zstd.ZstdError:
return zstd.ZstdDecompressor().decompress(payload, max_output_size=ZSTD_MAX_OUTPUT_SIZE)
with zstd.ZstdDecompressor().stream_reader(io.BytesIO(payload), read_across_frames=True) as reader:
return reader.read()
11 changes: 11 additions & 0 deletions test/test_codec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,3 +121,14 @@ def test_zstd():
b1 = random_string(100).encode('utf-8')
b2 = zstd_decode(zstd_encode(b1))
assert b1 == b2


@pytest.mark.skipif(not has_zstd(), reason="Zstd not available")
def test_zstd_multi_frame():
"""Test that zstd_decode handles multiple concatenated zstd frames."""
frame1_data = b'some payload data ' * 100
frame2_data = b'another frame of data ' * 100
# Concatenate two independently compressed zstd frames
multi_frame_payload = zstd_encode(frame1_data) + zstd_encode(frame2_data)
result = zstd_decode(multi_frame_payload)
assert result == frame1_data + frame2_data
Loading