Check for wakeup socket errors on read and close and reinit to reset#2482
Merged
Check for wakeup socket errors on read and close and reinit to reset#2482
Conversation
dpkp
force-pushed
the
dpkp/wakeup-socketpair-recycle
branch
from
80f015a to
f460b26
Compare
This was referenced Feb 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to be a bit more defensive with wakeup socketpair. Check for socket error and rebuild socketpair if necessary. Use a
_wakingflag to avoid writing more bytes to the socketpair when it's not needed. Raise errors on failed write attempts.