fix(useMultipleSelection): restore focus to active item after deletion#1695
Open
xianjianlf2 wants to merge 1 commit into
Open
fix(useMultipleSelection): restore focus to active item after deletion#1695xianjianlf2 wants to merge 1 commit into
xianjianlf2 wants to merge 1 commit into
Conversation
The "sets focus on active item" effect only depended on `activeIndex`, so when a selected item was removed without `activeIndex` changing (e.g. deleting the first item keeps `activeIndex` at 0), the effect did not re-run. With items rendered using stable keys, the removed item's DOM node unmounts and focus is lost to the document body instead of moving to the item that now occupies the active index. Add `selectedItems.length` to the effect dependencies so focus is restored to the active item whenever an item is added or removed. Closes downshift-js#1614
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The "sets focus on active item" effect in
useMultipleSelectiononly depended onactiveIndex. When a selected item was removed withoutactiveIndexchanging (e.g. deleting the first item keepsactiveIndexat0), the effect did not re-run. With items rendered using stable keys, the removed item's DOM node unmounts and focus is lost to the document body instead of moving to the item that now occupies the active index.Fix
Add
selectedItems.lengthto the effect dependencies so focus is restored to the active item whenever an item is added or removed.Testing
Added a test in
getSelectedItemProps.test.jscovering focus restoration after deleting a selected item (with a supporting helper intestUtils.js). The existinguseMultipleSelectiontest suite continues to pass.Closes #1614