fix: preserve pending a11y status messages#1693
Open
puneetdixit200 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
What
Fixes an aria-live status edge case where an empty status message can cancel a pending non-empty status update from another
useA11yMessageStatuscaller.Why
When hooks such as
useMultipleSelectionanduseSelectare composed together, one hook can have a real status message ready while a neighboring hook reports no status for the same render cycle. The empty status should be a no-op, not a cancellation of the pending message. This is related to #1298.How
useA11yMessageStatusnow returns early whengetA11yStatusMessagereturns an empty value, before the shared debounced updater is called.Changes
Checklist
Verified with:
CI=true npm test -- src/hooks/utils/__tests__/useA11yMessageStatus.multiple.test.ts --runInBandCI=true npm test -- src/hooks/utils/__tests__/useA11yMessageStatus.test.ts --runInBandCI=true npm test -- src/hooks/useMultipleSelection/__tests__/props.test.js --runInBandCI=true npm test -- src/hooks/useSelect/__tests__/props.test.js --runInBandnpm run test:tsnpx prettier --check src/hooks/utils/useA11yMessageStatus.ts src/hooks/utils/__tests__/useA11yMessageStatus.multiple.test.ts