dev: fix leftover typescript migration issues#1691
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses infrastructure regressions that surfaced after the TypeScript migration (PR #1683), primarily impacting Docusaurus styling and source-map/debugging behavior.
Changes:
- Updates root TypeScript compiler settings (module resolution and output-related options).
- Adjusts Docusaurus TypeScript settings and moves page CSS loading into
docusaurus.config.js. - Forces Webpack source-map generation for the Docusaurus build.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.json | Tweaks TypeScript compiler options used across the repo. |
| docusaurus/tsconfig.json | Overrides TS options for the Docusaurus app build/typecheck. |
| docusaurus/pages/useTagGroupCombobox.tsx | Removes per-page CSS imports (style now loaded globally). |
| docusaurus/pages/useTagGroup.tsx | Removes per-page CSS import (style now loaded globally). |
| docusaurus/pages/useSelect.tsx | Removes per-page CSS import (style now loaded globally). |
| docusaurus/pages/useMultipleSelect.tsx | Removes per-page CSS import (style now loaded globally). |
| docusaurus/pages/useMultipleCombobox.tsx | Removes per-page CSS import (style now loaded globally). |
| docusaurus/pages/useCombobox.tsx | Removes per-page CSS import (style now loaded globally). |
| docusaurus/pages/combobox.tsx | Removes per-page CSS import (style now loaded globally). |
| docusaurus.config.js | Adds theme.customCss entries and forces devtool: 'source-map'. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🎉 This PR is included in version 9.3.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
What
After the TS migration some infra errors appeared in the repo. Fixing them.
Why
How
Changes
Checklist