Skip to content

fix(disabled): remove disabled from spread regression#1689

Open
silviuaavram wants to merge 1 commit into
masterfrom
fix/disabled-spread-and-open-index
Open

fix(disabled): remove disabled from spread regression#1689
silviuaavram wants to merge 1 commit into
masterfrom
fix/disabled-spread-and-open-index

Conversation

@silviuaavram
Copy link
Copy Markdown
Collaborator

Pull Request

What

Why

How

Changes

Checklist

  • Documentation
  • Tests
  • TypeScript Types
  • Ready to be merged

Copilot AI review requested due to automatic review settings June 3, 2026 07:29
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts useSelect and useCombobox prop getters so that disabled is no longer included in the returned props object by default (when not explicitly provided), addressing a regression where disabled: undefined could be spread onto consumer elements.

Changes:

  • Update getToggleButtonProps / getInputProps implementations to avoid explicitly returning disabled, and gate handler attachment using the provided disabled option (rest.disabled).
  • Tighten TypeScript annotations for useSelect / useCombobox prop getter parameters (using the corresponding *Options types and GetPropsCommonOptions).
  • Add regression tests asserting the default prop getter outputs no longer include disabled by default.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/hooks/useSelect/index.ts Stops explicitly returning disabled in getToggleButtonProps and uses rest.disabled to decide whether to attach handlers.
src/hooks/useSelect/tests/getToggleButtonProps.test.js Adds a regression test for default toggle button props shape.
src/hooks/useCombobox/index.types.ts Updates getInputProps return value typing to no longer always include disabled by default.
src/hooks/useCombobox/index.ts Stops explicitly returning disabled in getToggleButtonProps/getInputProps and uses rest.disabled to decide whether to attach handlers.
src/hooks/useCombobox/tests/getToggleButtonProps.test.js Adds a regression test for default toggle button props shape.
src/hooks/useCombobox/tests/getInputProps.test.js Adds a regression test for default input props shape.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/hooks/useSelect/__tests__/getToggleButtonProps.test.js
Comment thread src/hooks/useCombobox/__tests__/getToggleButtonProps.test.js
Comment thread src/hooks/useCombobox/__tests__/getInputProps.test.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants