Improve node rendering and canvas UI quality#8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the node-rendering and canvas UI QA plan from
doc/NODE_RENDERING_UI_QA.md.What changed
prepareGeometryChange()ordering for Document, Thinking, and Connection items.Root causes
The main issues were duplicated rendering behavior across QGraphics items, geometry notifications occurring after bounds/path mutation, view-specific assumptions inside scene painting, and interaction paths that scanned or repainted more of the graph than necessary.
Validation
python -m pytest -q: 401 passed, one existing pytest-asyncio deprecation warning.python -m compileall -q .: passed.git diff --check: passed.No model/API calls or unrelated files were included.