Skip to content

Refactor canvas utility tools for production reliability #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dovvnloading merged 1 commit into from
Jul 15, 2026
Merged

Refactor canvas utility tools for production reliability #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 27 additions & 6 deletions graphlink_app/graphlink_canvas/graphlink_canvas_frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,12 @@ def __init__(self, nodes, parent=None):
self.setAcceptHoverEvents(True)

# Load icons for the lock/unlock button.
self.lock_icon = qta.icon('fa.lock', color='#ffffff')
self.unlock_icon = qta.icon('fa.unlock-alt', color='#ffffff')
self.lock_icon_hover = qta.icon('fa.lock', color=get_semantic_color("status_info").name())
self.unlock_icon_hover = qta.icon('fa.unlock-alt', color=get_semantic_color("status_success").name())
# QtAwesome's legacy ``fa`` prefix is not installed in current releases;
# use the Font Awesome 5 solid set used by the rest of the canvas.
self.lock_icon = qta.icon('fa5s.lock', color='#ffffff')
self.unlock_icon = qta.icon('fa5s.unlock-alt', color='#ffffff')
self.lock_icon_hover = qta.icon('fa5s.lock', color=get_semantic_color("status_info").name())
self.unlock_icon_hover = qta.icon('fa5s.unlock-alt', color=get_semantic_color("status_success").name())

# State attributes
self.is_locked = True
Expand Down Expand Up @@ -82,6 +84,7 @@ def __init__(self, nodes, parent=None):
self.resizing = False
self.resize_start_rect = None
self.resize_start_pos = None
self._user_resized = False

# Animation for the "unlocked" state outline.
self.outline_animation = QVariantAnimation()
Expand Down Expand Up @@ -284,9 +287,10 @@ def updateGeometry(self):
self.rect = QRectF(0, 0, 320, 180)
self._update_title_editor_geometry()
return
old_rect = QRectF(self.rect)
new_rect = self.calculate_minimum_size()
final_rect = old_rect.united(new_rect) if old_rect.isValid() else new_rect
final_rect = new_rect
if self._user_resized and self.rect.isValid():
final_rect = self.rect.united(new_rect)

if final_rect != self.rect:
self.prepareGeometryChange()
Expand All @@ -299,6 +303,13 @@ def updateGeometry(self):
if parent and isinstance(parent, Container):
parent.updateGeometry()

def fit_to_content(self):
"""Reset manual bounds to the current membership bounds."""
self._user_resized = False
self.updateGeometry()
self._update_child_connections()
self.update()

def boundingRect(self):
"""Returns the bounding rectangle of the item."""
return self.rect
Expand Down Expand Up @@ -456,6 +467,7 @@ def mouseMoveEvent(self, event):
if new_rect != self.rect:
self.prepareGeometryChange()
self.rect = new_rect
self._user_resized = True
self._update_title_editor_geometry()
self._update_child_connections()

Expand Down Expand Up @@ -585,6 +597,15 @@ def keyPressEvent(self, event):
event.accept()
return

if (
event.key() == Qt.Key.Key_F
and event.modifiers() & Qt.KeyboardModifier.ControlModifier
and event.modifiers() & Qt.KeyboardModifier.ShiftModifier
):
self.fit_to_content()
event.accept()
return

return super().keyPressEvent(event)

def paint(self, painter, option, widget=None):
Expand Down
63 changes: 58 additions & 5 deletions graphlink_app/graphlink_canvas/graphlink_canvas_note.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import markdown
import qtawesome as qta
from uuid import uuid4

from PySide6.QtWidgets import QDialog, QGraphicsItem, QApplication, QMessageBox
from PySide6.QtCore import Qt, QRectF, QPointF, QTimer
Expand All @@ -26,6 +27,7 @@ class Note(QGraphicsItem):
DEFAULT_WIDTH = 200
DEFAULT_HEIGHT = 150
MAX_HEIGHT = 500
MAX_CONTENT_LENGTH = 100_000
CONTROL_GUTTER = 25
SCROLLBAR_PADDING = 5

Expand All @@ -46,6 +48,12 @@ def __init__(self, pos, parent=None):
self.setAcceptHoverEvents(True)
self.is_system_prompt = False
self.is_summary_note = False
self.persistent_id = uuid4().hex
self.note_role = "manual"
self.source_ids = []
self.operation_id = ""
self.source_revisions = {}
self.provider_snapshot = {}

# Geometry and appearance
self.width = self.DEFAULT_WIDTH
Expand All @@ -58,6 +66,8 @@ def __init__(self, pos, parent=None):
self.edit_text = ""
self.cursor_pos = 0
self.cursor_visible = True
self._edit_history = []
self._edit_redo = []

# State for text selection
self.selection_start = 0
Expand Down Expand Up @@ -94,11 +104,14 @@ def content(self, new_content):
Sets the note's content. If not in editing mode, it immediately updates
the QTextDocument for rendering.
"""
new_content = str(new_content or "")[:self.MAX_CONTENT_LENGTH]
if self._content != new_content:
self._content = new_content
if not self.editing:
self._setup_document()
self.update()
if self.scene() and hasattr(self.scene(), "_schedule_scene_changed"):
self.scene()._schedule_scene_changed()

def _setup_document(self):
"""
Expand Down Expand Up @@ -387,6 +400,7 @@ def mousePressEvent(self, event):
elif self.color_button_rect.contains(event.pos()):
self.show_color_picker()
event.accept()
return

if event.button() == Qt.MouseButton.LeftButton and self.scene():
self.scene().is_dragging_item = True
Expand Down Expand Up @@ -420,6 +434,8 @@ def mouseDoubleClickEvent(self, event):
if not self.editing:
self.editing = True
self.edit_text = self.content
self._edit_history = []
self._edit_redo = []

char_pos = self.get_char_pos_at_x(event.pos().x(), event.pos().y())
text = self.edit_text
Expand Down Expand Up @@ -448,12 +464,17 @@ def keyPressEvent(self, event):
elif event.key() == Qt.Key.Key_V: self.paste_text(); return
elif event.key() == Qt.Key.Key_X: self.cut_selection(); return
elif event.key() == Qt.Key.Key_A: self.select_all(); return
elif event.key() == Qt.Key.Key_Z:
self.undo_edit(); return
elif event.key() == Qt.Key.Key_Y:
self.redo_edit(); return

if event.key() == Qt.Key.Key_Return and event.modifiers() & Qt.KeyboardModifier.ControlModifier:
self.finishEditing()
elif event.key() == Qt.Key.Key_Escape:
self.editing = False; self.cursor_timer.stop(); self.update()
elif event.key() in (Qt.Key.Key_Backspace, Qt.Key.Key_Delete):
self._push_edit_snapshot()
if self.selection_start != self.selection_end: self.delete_selection()
elif event.key() == Qt.Key.Key_Backspace and self.cursor_pos > 0:
self.edit_text = self.edit_text[:self.cursor_pos-1] + self.edit_text[self.cursor_pos:]
Expand Down Expand Up @@ -492,13 +513,15 @@ def keyPressEvent(self, event):
self.update()
elif event.key() == Qt.Key.Key_Return:
# Insert newline.
self._push_edit_snapshot()
if self.selection_start != self.selection_end: self.delete_selection()
self.edit_text = self.edit_text[:self.cursor_pos] + '\n' + self.edit_text[self.cursor_pos:]
self.cursor_pos += 1; self.selection_start = self.selection_end = self.cursor_pos; self.update()
elif len(event.text()) and event.text().isprintable():
# Insert typed character.
self._push_edit_snapshot()
if self.selection_start != self.selection_end: self.delete_selection()
self.edit_text = self.edit_text[:self.cursor_pos] + event.text() + self.edit_text[self.cursor_pos:]
self.edit_text = (self.edit_text[:self.cursor_pos] + event.text() + self.edit_text[self.cursor_pos:])[:self.MAX_CONTENT_LENGTH]
self.cursor_pos += 1; self.selection_start = self.selection_end = self.cursor_pos; self.update()

def wheelEvent(self, event):
Expand All @@ -525,24 +548,50 @@ def update_scroll_position(self, value):
self.scroll_value = value; self.update()

# --- Text manipulation methods ---
def _push_edit_snapshot(self):
if not self._edit_history or self._edit_history[-1] != self.edit_text:
self._edit_history.append(self.edit_text)
self._edit_redo.clear()

def _restore_edit_text(self, text):
self.edit_text = str(text or "")[:self.MAX_CONTENT_LENGTH]
self.cursor_pos = min(self.cursor_pos, len(self.edit_text))
self.selection_start = self.selection_end = self.cursor_pos
self.update()

def undo_edit(self):
if not self._edit_history:
return
self._edit_redo.append(self.edit_text)
self._restore_edit_text(self._edit_history.pop())

def redo_edit(self):
if not self._edit_redo:
return
self._edit_history.append(self.edit_text)
self._restore_edit_text(self._edit_redo.pop())

def copy_selection(self):
if self.selection_start != self.selection_end:
start, end = min(self.selection_start, self.selection_end), max(self.selection_start, self.selection_end)
QApplication.clipboard().setText(self.edit_text[start:end])

def cut_selection(self):
if self.selection_start != self.selection_end:
self._push_edit_snapshot()
self.copy_selection(); self.delete_selection()

def paste_text(self):
text = QApplication.clipboard().text()
if text:
self._push_edit_snapshot()
if self.selection_start != self.selection_end: self.delete_selection()
self.edit_text = self.edit_text[:self.cursor_pos] + text + self.edit_text[self.cursor_pos:]
self.edit_text = (self.edit_text[:self.cursor_pos] + text + self.edit_text[self.cursor_pos:])[:self.MAX_CONTENT_LENGTH]
self.cursor_pos += len(text); self.selection_start = self.selection_end = self.cursor_pos; self.update()

def delete_selection(self):
if self.selection_start != self.selection_end:
self._push_edit_snapshot()
start, end = min(self.selection_start, self.selection_end), max(self.selection_start, self.selection_end)
self.edit_text = self.edit_text[:start] + self.edit_text[end:]
self.cursor_pos = self.selection_start = self.selection_end = start
Expand All @@ -568,10 +617,14 @@ def hoverLeaveEvent(self, event):

def show_color_picker(self):
"""Opens the color picker dialog."""
dialog = ColorPickerDialog(self.scene().views()[0])
scene = self.scene()
if scene is None or not scene.views():
return
view = scene.views()[0]
dialog = ColorPickerDialog(view)
note_pos = self.mapToScene(self.color_button_rect.topRight())
view_pos = self.scene().views()[0].mapFromScene(note_pos)
global_pos = self.scene().views()[0].mapToGlobal(view_pos)
view_pos = view.mapFromScene(note_pos)
global_pos = view.mapToGlobal(view_pos)
dialog.move(global_pos.x() + 10, global_pos.y())
if dialog.exec() == QDialog.DialogCode.Accepted:
color, color_type = dialog.get_selected_color()
Expand Down
Loading