Modernize Graphlink Composer to a production-grade request surface#11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ComposerController.Why
The previous Composer split visual controls from the request lifecycle. Context was implicit, send/recovery state was distributed across
ChatWindowandWindowActionsMixin, and failed sends cleared user work. The new shell gives the user a single, inspectable interaction surface while keeping the migration compatible with the existing graph worker contracts.Validation
QT_QPA_PLATFORM=offscreen python -m pytest graphlink_app/tests -qpython -m compileall -q graphlink_appgit diff --checkThe local-only proposal at
doc/COMPOSER_SOTA_REFACTOR_PLAN.mdremains ignored and is intentionally not part of this PR.