Fix InvalidCastException in ComboBoxAutomationPeer / forward Scroll to ItemsControl#10877
Open
h3xds1nz wants to merge 1 commit intodotnet:mainfrom
Open
Fix InvalidCastException in ComboBoxAutomationPeer / forward Scroll to ItemsControl#10877h3xds1nz wants to merge 1 commit intodotnet:mainfrom
h3xds1nz wants to merge 1 commit intodotnet:mainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #10877 +/- ##
===================================================
- Coverage 13.48885% 2.98819% -10.50066%
===================================================
Files 3317 3319 +2
Lines 664749 664885 +136
Branches 74643 74673 +30
===================================================
- Hits 89667 19868 -69799
- Misses 572488 644836 +72348
+ Partials 2594 181 -2413
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes
InvalidCastExceptioninComboBoxAutomationPeerwhich occurs becauseComboBoxAutomationPeernor its parents implementIScrollProviderdirectly and hence the whole code block is just wrong as it will never work.We should use the
ItemsControlAutomationPeerimplementation to provide the interface viaScrollHost/ScrollViewer, which should be done only if the drop-down is open. See https://learn.microsoft.com/en-us/windows/win32/winauto/uiauto-supportcomboboxcontroltype.Reproduction steps are easy:
Customer Impact
Better performance and correct interface when the dropdown is open, improved accessibility.
Regression
Yes, this was introduced in #1278, guess the comment was misunderstood by the implementor and nobody bothered to check/test during review.
Testing
Local build, exploring the automation tree, ensuring the exception no longer happens.
Risk
Low.