Fix WebBrowser control blocks accelerators of buttons on form#14717
Open
JayashreeSF3546 wants to merge 1 commit into
Open
Fix WebBrowser control blocks accelerators of buttons on form#14717JayashreeSF3546 wants to merge 1 commit into
JayashreeSF3546 wants to merge 1 commit into
Conversation
LeafShi1
reviewed
Jul 10, 2026
LeafShi1
reviewed
Jul 10, 2026
| PInvoke.GetCursorPos(out Point p); | ||
| msg.pt = p; | ||
| if (!PInvoke.IsAccelerator(new HandleRef<HACCEL>(this, controlInfo.hAccel), controlInfo.cAccel, &msg, lpwCmd: null)) | ||
| if (PInvoke.IsAccelerator(new HandleRef<HACCEL>(this, controlInfo.hAccel), controlInfo.cAccel, &msg, lpwCmd: null)) |
Member
There was a problem hiding this comment.
the ! in the current WinForms code was introduced during the .NET Framework → .NET port — a genuine regression. The PR restores the original
LeafShi1
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8862
Proposed changes
WebBrowserBaseby correcting theIsAccelerator(...)condition.WebBrowseris present in the control hierarchy.Customer Impact
Alt+<mnemonic>keys (for exampleAlt+B,Alt+O) were blocked when aWebBrowsercontrol existed on the form/user control.Regression?
Risk
WebBrowsermnemonic/accelerator handling and corrects invertedIsAccelerator(...)logic.WebBrowserhandled keys that were not its own accelerators.Screenshots
NA
Test methodology
UserControlcontainingTextBox,Panel,WebBrowser, and a mnemonicButton.WebBrowserappears before the button in tab order.&OK) are not blocked byWebBrowser.Accessibility testing
Test environment(s)
Microsoft Reviewers: Open in CodeFlow