Skip to content

Fix Issue 14005: [DarkMode] the Pane in the Anchor Editor should adapt to the dark mode #14715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SimonZhao888 wants to merge 3 commits into
base: main
Choose a base branch
from
+13 −1
Open

Fix Issue 14005: [DarkMode] the Pane in the Anchor Editor should adapt to the dark mode #14715

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d80977d
[DarkMode] the Pane in the Anchor Editor should adapt to the dark mode
Jul 8, 2026
cbb2082
Handle feedback
Jul 10, 2026
fa86029
Method for updating the fill control
Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/AnchorEditor.AnchorUI.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,15 @@ private class ControlPlaceholder : Control
{
public ControlPlaceholder()
{
BackColor = SystemColors.Control;
if (Application.IsDarkModeEnabled)

@LeafShi1 LeafShi1 Jul 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: the dark-mode decision is duplicated here (for BackColor) and again in OnPaint. Since BackColor is captured only at construction while OnPaint re-evaluates Application.IsDarkModeEnabled on every paint, the two could diverge if the process color mode changes after this control is created. Consider centralizing the decision, or relying solely on OnPaint.

@SimonZhao888 SimonZhao888 Jul 10, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ControlPaint.DrawButton(e.Graphics, rc, ButtonState.Normal); draws a button but does not fill it with color; therefore, we need to fill it when in dark mode.

{
BackColor = SystemColors.ControlDark;
}
else
{
BackColor = SystemColors.Control;
}

TabStop = false;
SetStyle(ControlStyles.Selectable, false);
}
Expand All @@ -206,6 +214,10 @@ protected override void OnPaint(PaintEventArgs e)
{
Rectangle rc = ClientRectangle;
ControlPaint.DrawButton(e.Graphics, rc, ButtonState.Normal);
if (Application.IsDarkModeEnabled)
{
e.Graphics.Clear(BackColor);
}
}
}

Expand Down