Fixes issue 14400: Pasting controls via CommandSet.OnMenuPaste stopped working when hosting the WinForms designer#14403
Open
LeafShi1 wants to merge 1 commit intodotnet:mainfrom
Conversation
…d working when hosting the WinForms designer
LeafShi1
requested review from
KlausLoeffelmann,
SimonZhao888,
Copilot and
ricardobossan
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes WinForms designer Paste handling by correctly recognizing when the paste target is an IOleDragClient found via the ITreeDesigner chain, ensuring the paste logic executes for that scenario.
Changes:
- Set
dragClient = truewhen anIOleDragClientis discovered while walking theITreeDesignerhierarchy duringOnMenuPaste.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14400
Root cause
The logic of
dragClient=truewas accidentally deleted in Commit commit 5978f22,This resulted in the local flag
dragClientremainingfalsewithin theOnMenuPastemethod—even when anIOleDragClientdesigner had been successfully located. As a result, the entire paste path guarded byif (dragClient)was never executedProposed changes
CommandSet.OnMenuPaste, when anIOleDragClientdesigner is found,dragClientis simultaneously set totrue, thereby restoring the behavior of adding controls via the Paste command within a managed designer.Customer Impact
Regression?
Risk
Microsoft Reviewers: Open in CodeFlow