Fix visibility logic for addNewPanel in DesignBindingPicker to use _dataSourceProviderService#14133
Open
LeafShi1 wants to merge 2 commits intodotnet:mainfrom
Open
Fix visibility logic for addNewPanel in DesignBindingPicker to use _dataSourceProviderService#14133LeafShi1 wants to merge 2 commits intodotnet:mainfrom
LeafShi1 wants to merge 2 commits intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the visibility logic for the _addNewPanel in the DesignBindingPicker control to properly respect the data source provider service's capabilities. The change restores behavior that aligns with .NET Framework by ensuring the "Add new Object Data Source" panel only appears when the data source provider service is available and supports adding new data sources.
Key Changes
- Re-enabled the previously commented-out visibility logic for _addNewPanel in the Pick method
- Updated the variable reference from the non-existent
dspSvcto the correct field_dataSourceProviderService
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #14133 +/- ##
===================================================
+ Coverage 76.01271% 77.16231% +1.14960%
===================================================
Files 3279 3279
Lines 645325 645328 +3
Branches 47720 47721 +1
===================================================
+ Hits 490529 497950 +7421
+ Misses 145491 143695 -1796
+ Partials 9305 3683 -5622
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
SimonZhao888
previously approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14132
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
Before
The "Add new Object Data Source" link & description shouldn't display in the DropDown panel for the DataSource & DisplayMember properties in the propertiGird
After
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow