Restore generated assets in Microsoft.CodeAnalysis.NetAnalyzers packages - #55899
Open
jeffhandley with Copilot wants to merge 6 commits into
Open
Restore generated assets in Microsoft.CodeAnalysis.NetAnalyzers packages#55899jeffhandley with Copilot wants to merge 6 commits into
jeffhandley with Copilot wants to merge 6 commits into
Conversation
|
Azure Pipelines: 3 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: jeffhandley <1031940+jeffhandley@users.noreply.github.com>
Co-authored-by: jeffhandley <1031940+jeffhandley@users.noreply.github.com>
Co-authored-by: jeffhandley <1031940+jeffhandley@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix missing rulesets subdirectory in published NetAnalyzers package
Restore generated assets in Microsoft.CodeAnalysis.NetAnalyzers packages
Aug 23, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1b62fb4f-3669-466b-bbcf-d0384626535c
jeffhandley
approved these changes
Aug 24, 2026
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the Microsoft.CodeAnalysis.NetAnalyzers package packing process so generated assets (rulesets, editorconfigs, global analyzer configs, and buildTransitive integration files) are included reliably by moving their inclusion from evaluation-time globs to a target that runs after generation and before NuGet collects package files.
Changes:
- Removed evaluation-time
<None Include=".../**/*" Pack="true" ... />entries that could be empty during a clean pack. - Added
IncludeGeneratedFilesInPackagetarget to inject the generated files into the packing item graph afterGenerateAnalyzerConfigAndDocumentationFilesruns.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1b62fb4f-3669-466b-bbcf-d0384626535c
jeffhandley
approved these changes
Aug 24, 2026
ViktorHofer
approved these changes
Aug 24, 2026
ViktorHofer
left a comment
ViktorHofer
left a comment
Member
There was a problem hiding this comment.
We noticed the same just last week. Thanks for fixing. Interestingly this did work before so something must have changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean one-pass packing evaluated generated-file globs before their outputs existed, omitting rulesets, editorconfigs, global analyzer configs, and
buildTransitiveintegration files. This also prevented package-provided analyzers such as CA1416 from receiving required MSBuild properties.