Skip to content

Test Utf8JsonReader code shape for ARM64 regression #132430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jozkee wants to merge 18 commits into
base: main
Choose a base branch
from
+22 −1
Draft

Test Utf8JsonReader code shape for ARM64 regression #132430

Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
66b30d9
Modernize System.Text.Json product code
eiriktsarpalis Jul 17, 2026
43560bc
Use pattern matching in System.Text.Json
eiriktsarpalis Jul 17, 2026
a271e68
Modernize JsonSchema.Deprecated storage
eiriktsarpalis Jul 20, 2026
7c12816
Update src/libraries/System.Text.Json/src/System/Text/Json/JsonEncode…
eiriktsarpalis Jul 20, 2026
b69a074
Expose PR 130976 history for perf bisection
eiriktsarpalis Aug 17, 2026
6ca403a
Test JsonEncodedText.GetHashCode code shape
eiriktsarpalis Aug 17, 2026
a3dd4f8
Restore private libunwind linker fallback for benchmark build
eiriktsarpalis Aug 17, 2026
e92960b
Test Utf8JsonReader pattern code shape
jozkee Aug 17, 2026
d354506
Restore JsonEncodedText null conditional
jozkee Aug 17, 2026
fa936cf
Restore IsTokenTypeString pattern
jozkee Aug 17, 2026
d8d1dba
Restore number digit range pattern
jozkee Aug 17, 2026
69b2a7c
Restore number terminator pattern
jozkee Aug 17, 2026
c514b6e
Restore number terminator assertion pattern
jozkee Aug 17, 2026
b3836f1
Restore exponent marker pattern
jozkee Aug 17, 2026
859de55
Restore exponent marker assertion pattern
jozkee Aug 17, 2026
9d37db3
Restore zero terminator pattern
jozkee Aug 17, 2026
89a87df
Restore number sign pattern
jozkee Aug 17, 2026
4d529c0
Restore line separator pattern
jozkee Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion src/coreclr/nativeaot/Runtime/Full/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,27 @@ if(NATIVEAOT_PRIVATE_LIBUNWIND_SOURCES)
# libunwind implementation symbols are resolved before localization. The
# localize list is generated only from the bundled libunwind source objects.
set(NATIVEAOT_PRIVATE_LIBUNWIND_SYMBOL_OBJECTS "$<FILTER:$<TARGET_OBJECTS:Runtime.PrivateLibunwind>,EXCLUDE,.*(UnwindHelpers|UnixNativeCodeManager)\\.cpp\\.o$>")
set(NATIVEAOT_PRIVATE_LIBUNWIND_LINKER "${CMAKE_LINKER}")
get_filename_component(NATIVEAOT_PRIVATE_LIBUNWIND_LINKER_NAME "${NATIVEAOT_PRIVATE_LIBUNWIND_LINKER}" NAME)
if(NATIVEAOT_PRIVATE_LIBUNWIND_LINKER_NAME MATCHES "^llvm-link(-[0-9.]+)?(\\.exe)?$")
set(NATIVEAOT_PRIVATE_LIBUNWIND_LINKER_VERSION "${CMAKE_MATCH_1}")
set(NATIVEAOT_PRIVATE_LIBUNWIND_LINKER_EXTENSION "${CMAKE_MATCH_2}")
get_filename_component(NATIVEAOT_PRIVATE_LIBUNWIND_TOOL_DIR "${NATIVEAOT_PRIVATE_LIBUNWIND_LINKER}" DIRECTORY)
find_program(NATIVEAOT_PRIVATE_LIBUNWIND_LD_LLD
NAMES "ld.lld${NATIVEAOT_PRIVATE_LIBUNWIND_LINKER_VERSION}${NATIVEAOT_PRIVATE_LIBUNWIND_LINKER_EXTENSION}" ld.lld
PATHS "${NATIVEAOT_PRIVATE_LIBUNWIND_TOOL_DIR}"
NO_DEFAULT_PATH)
if(NATIVEAOT_PRIVATE_LIBUNWIND_LD_LLD)
set(NATIVEAOT_PRIVATE_LIBUNWIND_LINKER "${NATIVEAOT_PRIVATE_LIBUNWIND_LD_LLD}")
else()
find_program(NATIVEAOT_PRIVATE_LIBUNWIND_LD NAMES ld)
if(NATIVEAOT_PRIVATE_LIBUNWIND_LD)
set(NATIVEAOT_PRIVATE_LIBUNWIND_LINKER "${NATIVEAOT_PRIVATE_LIBUNWIND_LD}")
else()
message(FATAL_ERROR "ld.lld (preferred) or ld is required to privatize NativeAOT libunwind symbols")
endif()
endif()
endif()

add_custom_command(
OUTPUT "${NATIVEAOT_PRIVATE_LIBUNWIND_OBJECT}"
Expand All @@ -48,7 +69,7 @@ if(NATIVEAOT_PRIVATE_LIBUNWIND_SOURCES)
"${NATIVEAOT_PRIVATE_LIBUNWIND_SYMBOLS_UNSORTED}"
COMMAND "${CMAKE_COMMAND}" -E rm -f
"${NATIVEAOT_PRIVATE_LIBUNWIND_SYMBOLS_UNSORTED}"
COMMAND "${CMAKE_LINKER}" -r $<TARGET_OBJECTS:Runtime.PrivateLibunwind> -o "${NATIVEAOT_PRIVATE_LIBUNWIND_OBJECT}"
COMMAND "${NATIVEAOT_PRIVATE_LIBUNWIND_LINKER}" -r $<TARGET_OBJECTS:Runtime.PrivateLibunwind> -o "${NATIVEAOT_PRIVATE_LIBUNWIND_OBJECT}"
COMMAND "${CMAKE_OBJCOPY}"
"--localize-symbols=${NATIVEAOT_PRIVATE_LIBUNWIND_SYMBOLS}"
"${NATIVEAOT_PRIVATE_LIBUNWIND_OBJECT}"
Expand Down
Loading