Skip to content

Add note clarifying TLS use in HttpListener #128084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wfurt merged 3 commits into from
May 13, 2026
+5 −0
Merged

Add note clarifying TLS use in HttpListener #128084

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0107b0f
Add note clarifying TLS use in HttpListener
wfurt May 12, 2026
04fdf68
Apply suggestions from code review
wfurt May 12, 2026
437d705
Apply suggestions from code review
wfurt May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/libraries/System.Net.HttpListener/src/System/Net/Managed/HttpConnection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,11 @@ public HttpConnection(Socket sock, HttpEndPointListener epl, bool secure, X509Ce
else
{
#pragma warning disable CA5359
// This part is actually never called because LoadCertificateAndKey always returns null
// and for managed implementation we never negotiate TLS. If this ever changes we will need to re-think
// how we deal with client certs and probably also remove "disable CA5359".
// Doing full validation brings its own problems ... like AIA processing and possibly access to untrusted sites.
// so that should probably be driven by user configuration.
Comment thread
wfurt marked this conversation as resolved.
Comment thread
wfurt marked this conversation as resolved.
_sslStream = HttpListener.CreateSslStream(new NetworkStream(sock, false), false, (t, c, ch, e) =>
{
if (c == null)
Expand Down
Loading