Skip to content

Work around illink incorrectly trimming static virtual implementations #128020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichalStrehovsky merged 7 commits into from
May 14, 2026
+11 −0
Merged

Work around illink incorrectly trimming static virtual implementations #128020

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7880c63
Initial plan
Copilot May 11, 2026
06ac10b
Add trimming test for Marshal.StructureToPtr with ByVal DateTime arra…
Copilot May 11, 2026
376b174
Preserve array marshaler metadata for trimming
Copilot May 11, 2026
15c4b5b
Clean up trimming test descriptor comments
Copilot May 11, 2026
4e7b47b
Add marshaler types for various structures
MichalStrehovsky May 13, 2026
57e3fa4
Remove VariantBoolMarshaler from ILLink descriptors
MichalStrehovsky May 13, 2026
2a42b11
Remove ByVal DateTime trimming test
Copilot May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/coreclr/System.Private.CoreLib/src/ILLink/ILLink.Descriptors.Shared.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,17 @@
<!-- Accessed via native code. -->
<type fullname="System.Runtime.InteropServices.CustomMarshalers.*" />

<!-- Works around https://github.com/dotnet/runtime/issues/128120 -->
<type fullname="System.StubHelpers.DateMarshaler" />
Comment thread
MichalStrehovsky marked this conversation as resolved.
Comment thread
MichalStrehovsky marked this conversation as resolved.
Comment thread
MichalStrehovsky marked this conversation as resolved.
<type fullname="System.StubHelpers.StructureMarshaler`1" />
<type fullname="System.StubHelpers.BlittableArrayMarshaler`1" />
<type fullname="System.StubHelpers.AnsiCharArrayMarshaler`2" />
Comment thread
MichalStrehovsky marked this conversation as resolved.
<type fullname="System.StubHelpers.LayoutClassMarshaler`1" />
Comment thread
MichalStrehovsky marked this conversation as resolved.
<type fullname="System.StubHelpers.BoolMarshaler`1" />
<type fullname="System.StubHelpers.LPWSTRMarshaler" />
<type fullname="System.StubHelpers.LPSTRArrayElementMarshaler`2" />
<type fullname="System.StubHelpers.BSTRArrayElementMarshaler" />
Comment thread
MichalStrehovsky marked this conversation as resolved.
Comment thread
MichalStrehovsky marked this conversation as resolved.

<!-- GetActualImplementationForArrayGenericIListOrIReadOnlyListMethod depends on slots of these interfaces not changing -->
<type fullname="System.Collections.Generic.IEnumerable`1" />
<type fullname="System.Collections.Generic.ICollection`1" />
Expand Down
Loading