Ensure that we consistently copy otherRegs#128010
Draft
tannergooding wants to merge 2 commits intodotnet:mainfrom
Draft
Ensure that we consistently copy otherRegs#128010tannergooding wants to merge 2 commits intodotnet:mainfrom
tannergooding wants to merge 2 commits intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the JIT’s “copy register assignment” helper logic to more consistently propagate multi-register (“otherRegs”) state across additional node kinds (locals, multireg ops, and JIT intrinsics), and adjusts some multireg handling in register-count/dump code to rely less on FEATURE_MULTIREG_RET compile-time gating.
Changes:
- Add
CopyOtherRegshelpers forGenTreeLclVar,GenTreeMultiRegOp, andGenTreeJitIntrinsic. - Update
GenTree::CopyRegto copy multireg state for calls, multireg ops (32-bit), copy/reload nodes, HW intrinsics, and multireg locals. - Refactor
GenTree::GetRegisterDstCount, and makegtDispMultiRegCount/gtDispRegValavailable underDEBUGwithoutFEATURE_MULTIREG_RETgating.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/coreclr/jit/gentree.h | Adds CopyOtherRegs helpers on several node types to support multireg state propagation. |
| src/coreclr/jit/gentree.cpp | Extends CopyReg logic and refactors GetRegisterDstCount; adjusts debug dump helpers’ feature gating. |
| src/coreclr/jit/compiler.h | Removes FEATURE_MULTIREG_RET gating for gtDispMultiRegCount declaration under DEBUG. |
Open
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.