Skip to content

Reduce Unsafe usage in TryWriteSignificand/TryHash helpers #127921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
EgorBo wants to merge 2 commits into
base: main
Choose a base branch
from
+67 −136
Draft

Reduce Unsafe usage in TryWriteSignificand/TryHash helpers #127921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91d76ad
Reduce Unsafe usage in TryWriteSignificand/TryHash helpers
EgorBo May 7, 2026
2fab70c
Forward NFloat IFloatingPoint TryWriteXxx to inner Single/Double helpers
EgorBo May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions src/libraries/System.IO.Hashing/src/System/IO/Hashing/XxHash128.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,17 +214,8 @@ public UInt128 GetCurrentHashAsUInt128()
[MethodImpl(MethodImplOptions.AggressiveInlining)]
private static void WriteBigEndian128(in Hash128 hash, Span<byte> destination)
{
ulong low = hash.Low64;
ulong high = hash.High64;
if (BitConverter.IsLittleEndian)
{
low = BinaryPrimitives.ReverseEndianness(low);
high = BinaryPrimitives.ReverseEndianness(high);
}

ref byte dest0 = ref MemoryMarshal.GetReference(destination);
Unsafe.WriteUnaligned(ref dest0, high);
Unsafe.WriteUnaligned(ref Unsafe.AddByteOffset(ref dest0, new IntPtr(sizeof(ulong))), low);
BinaryPrimitives.WriteUInt64BigEndian(destination, hash.High64);
BinaryPrimitives.WriteUInt64BigEndian(destination.Slice(sizeof(ulong)), hash.Low64);
}

private static Hash128 HashLength0To16(byte* source, uint length, ulong seed)
Expand Down
7 changes: 1 addition & 6 deletions src/libraries/System.IO.Hashing/src/System/IO/Hashing/XxHash3.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,12 +104,7 @@ public static bool TryHash(ReadOnlySpan<byte> source, Span<byte> destination, ou
if (destination.Length >= sizeof(long))
{
ulong hash = HashToUInt64(source, seed);

if (BitConverter.IsLittleEndian)
{
hash = BinaryPrimitives.ReverseEndianness(hash);
}
Unsafe.WriteUnaligned(ref MemoryMarshal.GetReference(destination), hash);
BinaryPrimitives.WriteUInt64BigEndian(destination, hash);

bytesWritten = HashLengthInBytes;
return true;
Expand Down
30 changes: 4 additions & 26 deletions src/libraries/System.Private.CoreLib/src/System/Decimal.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1175,19 +1175,8 @@ bool IFloatingPoint<decimal>.TryWriteSignificandBigEndian(Span<byte> destination
{
if (destination.Length >= (sizeof(uint) + sizeof(ulong)))
{
uint hi32 = _hi32;
ulong lo64 = _lo64;

if (BitConverter.IsLittleEndian)
{
hi32 = BinaryPrimitives.ReverseEndianness(hi32);
lo64 = BinaryPrimitives.ReverseEndianness(lo64);
}

ref byte address = ref MemoryMarshal.GetReference(destination);

Unsafe.WriteUnaligned(ref address, hi32);
Unsafe.WriteUnaligned(ref Unsafe.AddByteOffset(ref address, sizeof(uint)), lo64);
BinaryPrimitives.WriteUInt32BigEndian(destination, _hi32);
BinaryPrimitives.WriteUInt64BigEndian(destination.Slice(sizeof(uint)), _lo64);

bytesWritten = sizeof(uint) + sizeof(ulong);
return true;
Expand All @@ -1204,19 +1193,8 @@ bool IFloatingPoint<decimal>.TryWriteSignificandLittleEndian(Span<byte> destinat
{
if (destination.Length >= (sizeof(ulong) + sizeof(uint)))
{
ulong lo64 = _lo64;
uint hi32 = _hi32;

if (!BitConverter.IsLittleEndian)
{
lo64 = BinaryPrimitives.ReverseEndianness(lo64);
hi32 = BinaryPrimitives.ReverseEndianness(hi32);
}

ref byte address = ref MemoryMarshal.GetReference(destination);

Unsafe.WriteUnaligned(ref address, lo64);
Unsafe.WriteUnaligned(ref Unsafe.AddByteOffset(ref address, sizeof(ulong)), hi32);
BinaryPrimitives.WriteUInt64LittleEndian(destination, _lo64);
BinaryPrimitives.WriteUInt32LittleEndian(destination.Slice(sizeof(ulong)), _hi32);

bytesWritten = sizeof(ulong) + sizeof(uint);
return true;
Expand Down
36 changes: 28 additions & 8 deletions src/libraries/System.Private.CoreLib/src/System/Double.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -721,8 +721,7 @@ int IFloatingPoint<double>.GetExponentShortestBitLength()
/// <inheritdoc cref="IFloatingPoint{TSelf}.GetSignificandBitLength()" />
int IFloatingPoint<double>.GetSignificandBitLength() => 53;

/// <inheritdoc cref="IFloatingPoint{TSelf}.TryWriteExponentBigEndian(Span{byte}, out int)" />
bool IFloatingPoint<double>.TryWriteExponentBigEndian(Span<byte> destination, out int bytesWritten)
internal bool TryWriteExponentBigEndian(Span<byte> destination, out int bytesWritten)
{
if (BinaryPrimitives.TryWriteInt16BigEndian(destination, Exponent))
{
Expand All @@ -734,8 +733,13 @@ bool IFloatingPoint<double>.TryWriteExponentBigEndian(Span<byte> destination, ou
return false;
}

/// <inheritdoc cref="IFloatingPoint{TSelf}.TryWriteExponentLittleEndian(Span{byte}, out int)" />
bool IFloatingPoint<double>.TryWriteExponentLittleEndian(Span<byte> destination, out int bytesWritten)
/// <inheritdoc cref="IFloatingPoint{TSelf}.TryWriteExponentBigEndian(Span{byte}, out int)" />
bool IFloatingPoint<double>.TryWriteExponentBigEndian(Span<byte> destination, out int bytesWritten)
{
return TryWriteExponentBigEndian(destination, out bytesWritten);
}

internal bool TryWriteExponentLittleEndian(Span<byte> destination, out int bytesWritten)
{
if (BinaryPrimitives.TryWriteInt16LittleEndian(destination, Exponent))
{
Expand All @@ -747,8 +751,13 @@ bool IFloatingPoint<double>.TryWriteExponentLittleEndian(Span<byte> destination,
return false;
}

/// <inheritdoc cref="IFloatingPoint{TSelf}.TryWriteSignificandBigEndian(Span{byte}, out int)" />
bool IFloatingPoint<double>.TryWriteSignificandBigEndian(Span<byte> destination, out int bytesWritten)
/// <inheritdoc cref="IFloatingPoint{TSelf}.TryWriteExponentLittleEndian(Span{byte}, out int)" />
bool IFloatingPoint<double>.TryWriteExponentLittleEndian(Span<byte> destination, out int bytesWritten)
{
return TryWriteExponentLittleEndian(destination, out bytesWritten);
}

internal bool TryWriteSignificandBigEndian(Span<byte> destination, out int bytesWritten)
{
if (BinaryPrimitives.TryWriteUInt64BigEndian(destination, Significand))
{
Expand All @@ -760,8 +769,13 @@ bool IFloatingPoint<double>.TryWriteSignificandBigEndian(Span<byte> destination,
return false;
}

/// <inheritdoc cref="IFloatingPoint{TSelf}.TryWriteSignificandLittleEndian(Span{byte}, out int)" />
bool IFloatingPoint<double>.TryWriteSignificandLittleEndian(Span<byte> destination, out int bytesWritten)
/// <inheritdoc cref="IFloatingPoint{TSelf}.TryWriteSignificandBigEndian(Span{byte}, out int)" />
bool IFloatingPoint<double>.TryWriteSignificandBigEndian(Span<byte> destination, out int bytesWritten)
{
return TryWriteSignificandBigEndian(destination, out bytesWritten);
}

internal bool TryWriteSignificandLittleEndian(Span<byte> destination, out int bytesWritten)
{
if (BinaryPrimitives.TryWriteUInt64LittleEndian(destination, Significand))
{
Expand All @@ -773,6 +787,12 @@ bool IFloatingPoint<double>.TryWriteSignificandLittleEndian(Span<byte> destinati
return false;
}

/// <inheritdoc cref="IFloatingPoint{TSelf}.TryWriteSignificandLittleEndian(Span{byte}, out int)" />
bool IFloatingPoint<double>.TryWriteSignificandLittleEndian(Span<byte> destination, out int bytesWritten)
{
return TryWriteSignificandLittleEndian(destination, out bytesWritten);
}

//
// IFloatingPointConstants
//
Expand Down
81 changes: 4 additions & 77 deletions src/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/NFloat.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System.Buffers.Binary;
using System.Diagnostics.CodeAnalysis;
using System.Globalization;
using System.Numerics;
Expand Down Expand Up @@ -1040,97 +1039,25 @@ int IFloatingPoint<NFloat>.GetSignificandBitLength()
/// <inheritdoc cref="IFloatingPoint{TSelf}.TryWriteExponentBigEndian(Span{byte}, out int)" />
bool IFloatingPoint<NFloat>.TryWriteExponentBigEndian(Span<byte> destination, out int bytesWritten)
{
if (destination.Length >= sizeof(NativeExponentType))
{
NativeExponentType exponent = _value.Exponent;

if (BitConverter.IsLittleEndian)
{
exponent = BinaryPrimitives.ReverseEndianness(exponent);
}

Unsafe.WriteUnaligned(ref MemoryMarshal.GetReference(destination), exponent);

bytesWritten = sizeof(NativeExponentType);
return true;
}
else
{
bytesWritten = 0;
return false;
}
return _value.TryWriteExponentBigEndian(destination, out bytesWritten);
}

/// <inheritdoc cref="IFloatingPoint{TSelf}.TryWriteExponentLittleEndian(Span{byte}, out int)" />
bool IFloatingPoint<NFloat>.TryWriteExponentLittleEndian(Span<byte> destination, out int bytesWritten)
{
if (destination.Length >= sizeof(NativeExponentType))
{
NativeExponentType exponent = _value.Exponent;

if (!BitConverter.IsLittleEndian)
{
exponent = BinaryPrimitives.ReverseEndianness(exponent);
}

Unsafe.WriteUnaligned(ref MemoryMarshal.GetReference(destination), exponent);

bytesWritten = sizeof(NativeExponentType);
return true;
}
else
{
bytesWritten = 0;
return false;
}
return _value.TryWriteExponentLittleEndian(destination, out bytesWritten);
}

/// <inheritdoc cref="IFloatingPoint{TSelf}.TryWriteSignificandBigEndian(Span{byte}, out int)" />
bool IFloatingPoint<NFloat>.TryWriteSignificandBigEndian(Span<byte> destination, out int bytesWritten)
{
if (destination.Length >= sizeof(NativeSignificandType))
{
NativeSignificandType significand = _value.Significand;

if (BitConverter.IsLittleEndian)
{
significand = BinaryPrimitives.ReverseEndianness(significand);
}

Unsafe.WriteUnaligned(ref MemoryMarshal.GetReference(destination), significand);

bytesWritten = sizeof(NativeSignificandType);
return true;
}
else
{
bytesWritten = 0;
return false;
}
return _value.TryWriteSignificandBigEndian(destination, out bytesWritten);
}

/// <inheritdoc cref="IFloatingPoint{TSelf}.TryWriteSignificandLittleEndian(Span{byte}, out int)" />
bool IFloatingPoint<NFloat>.TryWriteSignificandLittleEndian(Span<byte> destination, out int bytesWritten)
{
if (destination.Length >= sizeof(NativeSignificandType))
{
NativeSignificandType significand = _value.Significand;

if (!BitConverter.IsLittleEndian)
{
significand = BinaryPrimitives.ReverseEndianness(significand);
}

Unsafe.WriteUnaligned(ref MemoryMarshal.GetReference(destination), significand);

bytesWritten = sizeof(NativeSignificandType);
return true;
}
else
{
bytesWritten = 0;
return false;
}
return _value.TryWriteSignificandLittleEndian(destination, out bytesWritten);
}

//
Expand Down
36 changes: 28 additions & 8 deletions src/libraries/System.Private.CoreLib/src/System/Single.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -716,8 +716,7 @@ int IFloatingPoint<float>.GetExponentShortestBitLength()
/// <inheritdoc cref="IFloatingPoint{TSelf}.GetSignificandBitLength()" />
int IFloatingPoint<float>.GetSignificandBitLength() => 24;

/// <inheritdoc cref="IFloatingPoint{TSelf}.TryWriteExponentBigEndian(Span{byte}, out int)" />
bool IFloatingPoint<float>.TryWriteExponentBigEndian(Span<byte> destination, out int bytesWritten)
internal bool TryWriteExponentBigEndian(Span<byte> destination, out int bytesWritten)
{
if (destination.Length >= sizeof(sbyte))
{
Expand All @@ -730,8 +729,13 @@ bool IFloatingPoint<float>.TryWriteExponentBigEndian(Span<byte> destination, out
return false;
}

/// <inheritdoc cref="IFloatingPoint{TSelf}.TryWriteExponentLittleEndian(Span{byte}, out int)" />
bool IFloatingPoint<float>.TryWriteExponentLittleEndian(Span<byte> destination, out int bytesWritten)
/// <inheritdoc cref="IFloatingPoint{TSelf}.TryWriteExponentBigEndian(Span{byte}, out int)" />
bool IFloatingPoint<float>.TryWriteExponentBigEndian(Span<byte> destination, out int bytesWritten)
{
return TryWriteExponentBigEndian(destination, out bytesWritten);
}

internal bool TryWriteExponentLittleEndian(Span<byte> destination, out int bytesWritten)
{
if (destination.Length >= sizeof(sbyte))
{
Expand All @@ -744,8 +748,13 @@ bool IFloatingPoint<float>.TryWriteExponentLittleEndian(Span<byte> destination,
return false;
}

/// <inheritdoc cref="IFloatingPoint{TSelf}.TryWriteSignificandBigEndian(Span{byte}, out int)" />
bool IFloatingPoint<float>.TryWriteSignificandBigEndian(Span<byte> destination, out int bytesWritten)
/// <inheritdoc cref="IFloatingPoint{TSelf}.TryWriteExponentLittleEndian(Span{byte}, out int)" />
bool IFloatingPoint<float>.TryWriteExponentLittleEndian(Span<byte> destination, out int bytesWritten)
{
return TryWriteExponentLittleEndian(destination, out bytesWritten);
}

internal bool TryWriteSignificandBigEndian(Span<byte> destination, out int bytesWritten)
{
if (BinaryPrimitives.TryWriteUInt32BigEndian(destination, Significand))
{
Expand All @@ -757,8 +766,13 @@ bool IFloatingPoint<float>.TryWriteSignificandBigEndian(Span<byte> destination,
return false;
}

/// <inheritdoc cref="IFloatingPoint{TSelf}.TryWriteSignificandLittleEndian(Span{byte}, out int)" />
bool IFloatingPoint<float>.TryWriteSignificandLittleEndian(Span<byte> destination, out int bytesWritten)
/// <inheritdoc cref="IFloatingPoint{TSelf}.TryWriteSignificandBigEndian(Span{byte}, out int)" />
bool IFloatingPoint<float>.TryWriteSignificandBigEndian(Span<byte> destination, out int bytesWritten)
{
return TryWriteSignificandBigEndian(destination, out bytesWritten);
}

internal bool TryWriteSignificandLittleEndian(Span<byte> destination, out int bytesWritten)
{
if (BinaryPrimitives.TryWriteUInt32LittleEndian(destination, Significand))
{
Expand All @@ -770,6 +784,12 @@ bool IFloatingPoint<float>.TryWriteSignificandLittleEndian(Span<byte> destinatio
return false;
}

/// <inheritdoc cref="IFloatingPoint{TSelf}.TryWriteSignificandLittleEndian(Span{byte}, out int)" />
bool IFloatingPoint<float>.TryWriteSignificandLittleEndian(Span<byte> destination, out int bytesWritten)
{
return TryWriteSignificandLittleEndian(destination, out bytesWritten);
}

//
// IFloatingPointConstants
//
Expand Down
Loading