-
Notifications
You must be signed in to change notification settings - Fork 5.4k
[cDAC] Add interpreter support for stack walking and diagnostics #126520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
max-charlamb
wants to merge
17
commits into
dotnet:main
Choose a base branch
from
max-charlamb:dev/max-charlamb/cdac-interpreter-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
5a5a7e6
[cDAC] Add interpreter support for stack walking and diagnostics
max-charlamb c1d3da6
[cDAC] Add interpreter dump tests for stack walking
max-charlamb 7aa3900
Fix ARM/ARM64 unwinder crash on interpreter IPs
max-charlamb a3cca28
Address PR self-review feedback
max-charlamb 788563b
Mirror native interpreter context updates in cDAC; address PR feedback
max-charlamb 2bcca07
Address PR feedback: route GetCodeHeaderData GC info decode by JIT ty…
max-charlamb b8937a9
Add interpreter SOS leg to runtime-diagnostics pipeline
9ea1221
[cDAC] Set first-arg register to InterpreterFrame in per-arch Inlined…
max-charlamb 3e32f6b
[cDAC] Allow GetILOffsetsByAddress to succeed for interpreter IPs
4ef488e
address comments
max-charlamb b307e0c
fix doubled frame issue
max-charlamb 99175ae
Add ISOSDacInterface GetCodeHeaderData test for interpreter methods
max-charlamb 68dac9b
Use full dumps for InterpreterStack to work around createdump bug
max-charlamb cb6f549
Sign-extend interpreter code address for GetCodeHeaderData test on 32…
max-charlamb d3b715c
Revert PrecodeStubs_Common.cs catch widening
max-charlamb 935ee59
Migrate InterpreterStackDumpTests.cs JitType usage to CodeKind
max-charlamb b7429c2
Address Copilot PR review feedback
max-charlamb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@janvorli @kotlarmilos - Please take a look at these contracts (the markdown files) and see what you think. Every type/field/algorithm included here becomes part of the interpreter's contract with diagnostic tools. Changing the data structures is possible, but its a breaking change that requires developers to update their tools so we'd only expect to do it rarely. Make sure the things documented here are things you'd expect to be reasonably stable over time or please suggest alternatives.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Want to bump @janvorli @kotlarmilos @jkotas, planning to merge this soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am sorry, I've missed the comment from @noahfalk last week. I'll look at it today.