Skip to content

Enclose keywords in quotes in logging generator messages, to improve translation quality #124960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akoeplinger merged 2 commits into from
Feb 27, 2026
Merged

Enclose keywords in quotes in logging generator messages, to improve translation quality #124960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
637a47d
Enclose keywords in quotes in messages, to improve translation quality
svick Feb 27, 2026
a44b29b
Merge branch 'main' into logging-strings-keywords
akoeplinger Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/Resources/Strings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@
<value>Multiple logging methods are using event id {0} in class {1}</value>
</data>
<data name="LoggingMethodMustReturnVoidMessage" xml:space="preserve">
<value>Logging methods must return void</value>
<value>Logging methods must return 'void'</value>
</data>
<data name="MissingLoggerArgumentTitle" xml:space="preserve">
<value>One of the arguments to a static logging method must implement the Microsoft.Extensions.Logging.ILogger interface</value>
Expand All @@ -147,13 +147,10 @@
<comment>{Locked="Microsoft.Extensions.Logging.ILogger"}</comment>
</data>
<data name="LoggingMethodShouldBeStaticMessage" xml:space="preserve">
<value>Logging methods must be static</value>
<value>Logging methods must be 'static'</value>
</data>
<data name="LoggingMethodMustBePartialMessage" xml:space="preserve">
<value>Logging methods must be partial</value>
</data>
<data name="LoggingMethodHasAllowsRefStructConstraintMessage" xml:space="preserve">
<value>Logging methods cannot have type parameters with 'allows ref struct' constraints</value>
<value>Logging methods must be 'partial'</value>
</data>
<data name="ShouldntMentionInTemplateMessage" xml:space="preserve">
<value>Don't include a template for {0} in the logging message since it is implicitly taken care of</value>
Expand All @@ -162,7 +159,7 @@
<value>Don't include exception parameters as templates in the logging message</value>
</data>
<data name="RedundantQualifierInMessageMessage" xml:space="preserve">
<value>Remove redundant qualifier (Info:, Warning:, Error:, etc) from the logging message since it is implicit in the specified log level.</value>
<value>Remove redundant qualifier ('Info:', 'Warning:', 'Error:', etc) from the logging message since it is implicit in the specified log level.</value>
</data>
<data name="RedundantQualifierInMessageTitle" xml:space="preserve">
<value>Redundant qualifier in logging message</value>
Expand Down Expand Up @@ -217,10 +214,10 @@
<value>Generating more than 6 arguments is not supported</value>
</data>
<data name="InvalidLoggingMethodParameterOutMessage" xml:space="preserve">
<value>Argument '{0}' is using the unsupported out parameter modifier</value>
<value>Argument '{0}' is using the unsupported 'out' parameter modifier</value>
</data>
<data name="InvalidLoggingMethodParameterOutTitle" xml:space="preserve">
<value>Argument is using the unsupported out parameter modifier</value>
<value>Argument is using the unsupported 'out' parameter modifier</value>
</data>
<data name="ShouldntReuseEventNamesMessage" xml:space="preserve">
<value>Multiple logging methods are using event name {0} in class {1}</value>
Expand All @@ -245,16 +242,19 @@
<value>Primary constructor parameter of type Microsoft.Extensions.Logging.ILogger is hidden by a field</value>
<comment>{Locked="Microsoft.Extensions.Logging.ILogger"}</comment>
</data>
<data name="LoggingMethodHasAllowsRefStructConstraintMessage" xml:space="preserve">
<value>Logging methods cannot have type parameters with 'allows ref struct' constraints</value>
</data>
<data name="InvalidLoggingMethodParameterParamsMessage" xml:space="preserve">
<value>Argument '{0}' is using the unsupported params or scoped parameter modifier</value>
<value>Argument '{0}' is using the unsupported 'params' or 'scoped' parameter modifier</value>
</data>
<data name="InvalidLoggingMethodParameterParamsTitle" xml:space="preserve">
<value>Argument is using the unsupported params or scoped parameter modifier</value>
<value>Argument is using the unsupported 'params' or 'scoped' parameter modifier</value>
</data>
<data name="InvalidLoggingMethodParameterRefStructMessage" xml:space="preserve">
<value>Parameter '{0}' is a ref struct, which is not supported by the logging source generator</value>
<value>Parameter '{0}' is a 'ref struct', which is not supported by the logging source generator</value>
</data>
<data name="InvalidLoggingMethodParameterRefStructTitle" xml:space="preserve">
<value>Logging method parameter is a ref struct</value>
<value>Logging method parameter is a 'ref struct'</value>
</data>
</root>
40 changes: 20 additions & 20 deletions src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/Resources/xlf/Strings.cs.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,13 @@
<note />
</trans-unit>
<trans-unit id="InvalidLoggingMethodParameterOutMessage">
<source>Argument '{0}' is using the unsupported out parameter modifier</source>
<target state="translated">Argument {0} používá nepodporovaný modifikátor výstupních parametrů.</target>
<source>Argument '{0}' is using the unsupported 'out' parameter modifier</source>
<target state="needs-review-translation">Argument {0} používá nepodporovaný modifikátor výstupních parametrů.</target>
<note />
</trans-unit>
<trans-unit id="InvalidLoggingMethodParameterOutTitle">
<source>Argument is using the unsupported out parameter modifier</source>
<target state="translated">Argument používá nepodporovaný modifikátor výstupních parametrů</target>
<source>Argument is using the unsupported 'out' parameter modifier</source>
<target state="needs-review-translation">Argument používá nepodporovaný modifikátor výstupních parametrů</target>
<note />
</trans-unit>
<trans-unit id="LoggingMethodHasBodyMessage">
Expand All @@ -53,18 +53,18 @@
<note />
</trans-unit>
<trans-unit id="LoggingMethodMustBePartialMessage">
<source>Logging methods must be partial</source>
<target state="translated">Metody protokolování musí být částečné.</target>
<source>Logging methods must be 'partial'</source>
<target state="needs-review-translation">Metody protokolování musí být částečné.</target>
<note />
</trans-unit>
<trans-unit id="LoggingMethodMustReturnVoidMessage">
<source>Logging methods must return void</source>
<target state="translated">Metody protokolování musí vracet void.</target>
<source>Logging methods must return 'void'</source>
<target state="needs-review-translation">Metody protokolování musí vracet void.</target>
<note />
</trans-unit>
<trans-unit id="LoggingMethodShouldBeStaticMessage">
<source>Logging methods must be static</source>
<target state="translated">Metody protokolování musí být statické.</target>
<source>Logging methods must be 'static'</source>
<target state="needs-review-translation">Metody protokolování musí být statické.</target>
<note />
</trans-unit>
<trans-unit id="LoggingUnsupportedLanguageVersionMessageFormat">
Expand Down Expand Up @@ -143,8 +143,8 @@
<note>{Locked="Microsoft.Extensions.Logging.ILogger"}</note>
</trans-unit>
<trans-unit id="RedundantQualifierInMessageMessage">
<source>Remove redundant qualifier (Info:, Warning:, Error:, etc) from the logging message since it is implicit in the specified log level.</source>
<target state="translated">Odeberte redundantní kvalifikátor (Informace:, Upozornění:, Chyba: atd.) ze zprávy o protokolování, protože je na zadané úrovni protokolu implicitní.</target>
<source>Remove redundant qualifier ('Info:', 'Warning:', 'Error:', etc) from the logging message since it is implicit in the specified log level.</source>
<target state="needs-review-translation">Odeberte redundantní kvalifikátor (Informace:, Upozornění:, Chyba: atd.) ze zprávy o protokolování, protože je na zadané úrovni protokolu implicitní.</target>
<note />
</trans-unit>
<trans-unit id="RedundantQualifierInMessageTitle">
Expand Down Expand Up @@ -203,23 +203,23 @@
<note />
</trans-unit>
<trans-unit id="InvalidLoggingMethodParameterParamsMessage">
<source>Argument '{0}' is using the unsupported params or scoped parameter modifier</source>
<target state="translated">Argument {0} používá nepodporované parametry nebo modifikátor parametrů s vymezeným oborem</target>
<source>Argument '{0}' is using the unsupported 'params' or 'scoped' parameter modifier</source>
<target state="new">Argument '{0}' is using the unsupported 'params' or 'scoped' parameter modifier</target>
<note />
</trans-unit>
<trans-unit id="InvalidLoggingMethodParameterParamsTitle">
<source>Argument is using the unsupported params or scoped parameter modifier</source>
<target state="translated">Argument používá nepodporované parametry nebo modifikátor parametrů s vymezeným oborem</target>
<source>Argument is using the unsupported 'params' or 'scoped' parameter modifier</source>
<target state="new">Argument is using the unsupported 'params' or 'scoped' parameter modifier</target>
<note />
</trans-unit>
<trans-unit id="InvalidLoggingMethodParameterRefStructMessage">
<source>Parameter '{0}' is a ref struct, which is not supported by the logging source generator</source>
<target state="translated">Parametr {0} je ref stuct, což není podporováno generátorem zdroje protokolování</target>
<source>Parameter '{0}' is a 'ref struct', which is not supported by the logging source generator</source>
<target state="new">Parameter '{0}' is a 'ref struct', which is not supported by the logging source generator</target>
<note />
</trans-unit>
<trans-unit id="InvalidLoggingMethodParameterRefStructTitle">
<source>Logging method parameter is a ref struct</source>
<target state="translated">Parametr metody protokolování je ref struct</target>
<source>Logging method parameter is a 'ref struct'</source>
<target state="new">Logging method parameter is a 'ref struct'</target>
<note />
</trans-unit>
</body>
Expand Down
40 changes: 20 additions & 20 deletions src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/Resources/xlf/Strings.de.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,13 @@
<note />
</trans-unit>
<trans-unit id="InvalidLoggingMethodParameterOutMessage">
<source>Argument '{0}' is using the unsupported out parameter modifier</source>
<target state="translated">Das Argument „{0}“ verwendet den nicht unterstützten Parametermodifizierer „out“.</target>
<source>Argument '{0}' is using the unsupported 'out' parameter modifier</source>
<target state="needs-review-translation">Das Argument „{0}“ verwendet den nicht unterstützten Parametermodifizierer „out“.</target>
<note />
</trans-unit>
<trans-unit id="InvalidLoggingMethodParameterOutTitle">
<source>Argument is using the unsupported out parameter modifier</source>
<target state="translated">Das Argument verwendet den nicht unterstützten Parametermodifizierer „out“.</target>
<source>Argument is using the unsupported 'out' parameter modifier</source>
<target state="needs-review-translation">Das Argument verwendet den nicht unterstützten Parametermodifizierer „out“.</target>
<note />
</trans-unit>
<trans-unit id="LoggingMethodHasBodyMessage">
Expand All @@ -53,18 +53,18 @@
<note />
</trans-unit>
<trans-unit id="LoggingMethodMustBePartialMessage">
<source>Logging methods must be partial</source>
<target state="translated">Protokollierungsmethoden müssen partiell sein.</target>
<source>Logging methods must be 'partial'</source>
<target state="needs-review-translation">Protokollierungsmethoden müssen partiell sein.</target>
<note />
</trans-unit>
<trans-unit id="LoggingMethodMustReturnVoidMessage">
<source>Logging methods must return void</source>
<target state="translated">Protokollierungsmethoden müssen leer zurückgegeben werden.</target>
<source>Logging methods must return 'void'</source>
<target state="needs-review-translation">Protokollierungsmethoden müssen leer zurückgegeben werden.</target>
<note />
</trans-unit>
<trans-unit id="LoggingMethodShouldBeStaticMessage">
<source>Logging methods must be static</source>
<target state="translated">Protokollierungsmethoden müssen statisch sein.</target>
<source>Logging methods must be 'static'</source>
<target state="needs-review-translation">Protokollierungsmethoden müssen statisch sein.</target>
<note />
</trans-unit>
<trans-unit id="LoggingUnsupportedLanguageVersionMessageFormat">
Expand Down Expand Up @@ -143,8 +143,8 @@
<note>{Locked="Microsoft.Extensions.Logging.ILogger"}</note>
</trans-unit>
<trans-unit id="RedundantQualifierInMessageMessage">
<source>Remove redundant qualifier (Info:, Warning:, Error:, etc) from the logging message since it is implicit in the specified log level.</source>
<target state="translated">Entfernen Sie den redundanten Qualifizierer (z. B. "Info:", "Warnung:" oder "Fehler:") aus der Protokollierungsmeldung, weil er auf der angegebenen Protokollebene implizit enthalten ist.</target>
<source>Remove redundant qualifier ('Info:', 'Warning:', 'Error:', etc) from the logging message since it is implicit in the specified log level.</source>
<target state="needs-review-translation">Entfernen Sie den redundanten Qualifizierer (z. B. "Info:", "Warnung:" oder "Fehler:") aus der Protokollierungsmeldung, weil er auf der angegebenen Protokollebene implizit enthalten ist.</target>
<note />
</trans-unit>
<trans-unit id="RedundantQualifierInMessageTitle">
Expand Down Expand Up @@ -203,23 +203,23 @@
<note />
</trans-unit>
<trans-unit id="InvalidLoggingMethodParameterParamsMessage">
<source>Argument '{0}' is using the unsupported params or scoped parameter modifier</source>
<target state="translated">Das Argument „{0}“ verwendet nicht unterstützte Parameter oder bereichsbezogene Parametermodifizierer.</target>
<source>Argument '{0}' is using the unsupported 'params' or 'scoped' parameter modifier</source>
<target state="new">Argument '{0}' is using the unsupported 'params' or 'scoped' parameter modifier</target>
<note />
</trans-unit>
<trans-unit id="InvalidLoggingMethodParameterParamsTitle">
<source>Argument is using the unsupported params or scoped parameter modifier</source>
<target state="translated">Das Argument verwendet nicht unterstützte Parameter oder bereichsbezogene Parametermodifizierer.</target>
<source>Argument is using the unsupported 'params' or 'scoped' parameter modifier</source>
<target state="new">Argument is using the unsupported 'params' or 'scoped' parameter modifier</target>
<note />
</trans-unit>
<trans-unit id="InvalidLoggingMethodParameterRefStructMessage">
<source>Parameter '{0}' is a ref struct, which is not supported by the logging source generator</source>
<target state="translated">Der Parameter „{0}“ ist eine Referenzstruktur, die vom Protokollierungsquellgenerator nicht unterstützt wird.</target>
<source>Parameter '{0}' is a 'ref struct', which is not supported by the logging source generator</source>
<target state="new">Parameter '{0}' is a 'ref struct', which is not supported by the logging source generator</target>
<note />
</trans-unit>
<trans-unit id="InvalidLoggingMethodParameterRefStructTitle">
<source>Logging method parameter is a ref struct</source>
<target state="translated">Der Parameter der Protokollierungsmethode ist eine Referenzstruktur.</target>
<source>Logging method parameter is a 'ref struct'</source>
<target state="new">Logging method parameter is a 'ref struct'</target>
<note />
</trans-unit>
</body>
Expand Down
Loading
Loading