Disable FileSystemWatcher_SymbolicLink_TargetsDirectory_Create_IncludeSubdirectories#124849
Open
Disable FileSystemWatcher_SymbolicLink_TargetsDirectory_Create_IncludeSubdirectories#124849
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-io |
…eSubdirectories on OSX with crossgen Co-authored-by: jtschuster <36744439+jtschuster@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix FileSystemWatcher symbolic link target directory test on OSX
Disable FileSystemWatcher_SymbolicLink_TargetsDirectory_Create_IncludeSubdirectories on OSX with crossgen
Feb 25, 2026
jtschuster
reviewed
Feb 25, 2026
src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.SymbolicLink.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: jtschuster <36744439+jtschuster@users.noreply.github.com>
Member
|
/azp run runtime-coreclr crossgen2 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
Disables a flaky FileSystemWatcher symbolic-link test specifically on macOS when running under ReadyToRun (crossgen2) test mode, aligning with the reported consistent failures in the crossgen2/ReadyToRun pipelines.
Changes:
- Added an
ActiveIssueskip condition forPlatformDetection.IsOSX && PlatformDetection.IsReadyToRunCompiledon the failing test, linked to #124847.
jkotas
reviewed
Feb 25, 2026
src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.SymbolicLink.cs
Outdated
Show resolved
Hide resolved
jtschuster
reviewed
Feb 25, 2026
src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.SymbolicLink.cs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileSystemWatcher_SymbolicLink_TargetsDirectory_Create_IncludeSubdirectoriesconsistently fails on macOS in crossgen2/ReadyToRun pipelines —ExpectNoEventfires unexpectedly on all three retry attempts.Changes
FileSystemWatcher.SymbolicLink.cs: Added[ActiveIssue("https://github.com/dotnet/runtime/issues/124847", typeof(PlatformDetection), nameof(PlatformDetection.IsOSX), nameof(PlatformDetection.IsReadyToRunCompiled))]to skip the test only when running on OSX with ReadyToRun compilation enabled, using theparamsconstructor overload to combine conditions without adding a new property.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.