Open
Conversation
dotnet-policy-service
bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-io |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Adler32Tests to validate the actual overflow boundary condition tied to Adler32’s delayed-modulo optimization (NMax), ensuring the test fails if NMax is reduced below the safe threshold.
Changes:
- Reworks
LargeInput_ExceedsNMaxto prime the hasher into a maximal checksum state, then append max-value bytes to stress 32-bit intermediate overflow behavior. - Updates expected checksum values to match the new (stronger) test construction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing test doesn't check the actual boundary condition. For example, if
NMaxis changed to8192in the Adler32 implementation, the tests still pass.This change correctly breaks if
NMaxis set as small as5553.