Skip to content

Set RuntimeType explicitly for wasm and wasm_coreclr micro benchmarks#5153

Open
ilonatommy wants to merge 1 commit intodotnet:mainfrom
ilonatommy:fix-coreclr-perf-autofiling-issues
Open

Set RuntimeType explicitly for wasm and wasm_coreclr micro benchmarks#5153
ilonatommy wants to merge 1 commit intodotnet:mainfrom
ilonatommy:fix-coreclr-perf-autofiling-issues

Conversation

@ilonatommy
Copy link
Member

Problem

Coreclr jobs are running fine, see: dotnet/runtime#125566 runtime-wasm-perf (Build Performance micro wasm_coreclr wasm coreclr_v8 linux x64 perfviper net11.0) but we don't get autofilling issues on them, like we do for mono.

Root cause

wasm_coreclr benchmark results are never reported to the perf autofiling system. The allTestHistory dashboard has zero wasm_coreclr entries despite the job running in CI.

--runtime-flavor is only passed via YAML for MAUI scenarios, so for wasm micro benchmarks runtime_flavor is None. This means:

  • wasm_coreclr: RuntimeType=None in configurations -> data lands in the wrong blob storage path and is never picked up by the autofiler,
  • wasm: RuntimeType not set at all in configurations ->happens to work but is implicit.

Fix

Auto-detect runtime_flavor from runtime_type for wasm micro benchmarks in run_performance_job.py, matching the existing pattern used by Android and iOS scenarios.

Set RuntimeType in get_run_configurations() for both wasm and wasm_coreclr so the configuration metadata is explicit.

Impact

  • wasm_coreclr: Fixes broken reporting — results will now appear in allTestHistory and be picked up by the perf autofiler
  • wasm (Mono): Adds explicit RuntimeType=mono to configurations. This changes the blob storage path for new data (previously had no RuntimeType key), but makes the metadata correct and future-proof
  • No impact on non-wasm scenarios

Copy link
Member

@pavelsavara pavelsavara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will leave the approval to @LoopedBard3


if args.run_kind == "micro":
if args.runtime_type == "wasm":
args.runtime_flavor = "mono"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would this break how the new data are compared to baseline or history ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants