Improve granularity of Perf.Utf8Encoding benchmarks#5048
Open
ylpoonlg wants to merge 1 commit intodotnet:mainfrom
Open
Improve granularity of Perf.Utf8Encoding benchmarks#5048ylpoonlg wants to merge 1 commit intodotnet:mainfrom
ylpoonlg wants to merge 1 commit intodotnet:mainfrom
Conversation
Implement the suggestions from dotnet#1512: * Break down benchmarks for Unicode validation and transcoding. * Call from `Encoding.UTF8` so that devirtualization can be tested.
Contributor
Author
|
cc @dotnet/arm64-contrib @a74nh @SwapnilGaikwad @tannergooding |
This was referenced Nov 17, 2025
Open
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the UTF-8 encoding microbenchmarks to exercise more Encoding.UTF8 APIs (including span-based overloads) while simplifying setup state.
Changes:
- Replace per-instance
UTF8Encodingusage withEncoding.UTF8calls. - Add new benchmarks for
GetCharCount, span-basedGetBytes/GetChars, andGetStringfrom bytes. - Adjust setup state to include both UTF-16 chars and UTF-8 bytes buffers.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+21
to
+32
| _string = File.ReadAllText(Path.Combine(TextFilesRootPath, $"{Input}.txt")); | ||
| _bytes = Encoding.UTF8.GetBytes(_string); | ||
| _chars = _string.ToCharArray(); | ||
| } | ||
|
|
||
| [Benchmark] | ||
| [MemoryRandomization] | ||
| public int GetByteCount() => _utf8Encoding.GetByteCount(_unicode); | ||
| public int GetByteCount() => Encoding.UTF8.GetByteCount(_string); | ||
|
|
||
| [Benchmark] | ||
| public byte[] GetBytes() => _utf8Encoding.GetBytes(_unicode); | ||
| [MemoryRandomization] | ||
| public int GetCharCount() => Encoding.UTF8.GetCharCount(_bytes); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the benchmark functions as suggested by #1512 :
GetByteCount: Covers UTF-16 validationGetCharCount: Covers UTF-8 validationGetBytesFromChars: Covers UTF-16 to UTF-8 transcodingGetCharsFromBytes: Covers UTF-8 to UTF-16 transcodingGetStringFromBytes: Covers UTF-8 validation, string allocation and UTF-16 transcodingGetBytesFromString: Covers UTF-16 validation, byte array instantiation and UTF-8 transcodingCall the methods from
Encoding.UTF8instead of anew UTF8Encoding()instance to test the JIT's devirtualization.