Emit assemblyName payload for FallbackAssemblyLoad EventSource events#14014
Open
AR-May wants to merge 1 commit into
Open
Emit assemblyName payload for FallbackAssemblyLoad EventSource events#14014AR-May wants to merge 1 commit into
AR-May wants to merge 1 commit into
Conversation
FallbackAssemblyLoadStart/Stop (events 97/98) declared an assemblyName parameter but called WriteEvent(97)/WriteEvent(98) without passing it, so the payload was silently dropped in ETW/EventPipe traces. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes MSBuild’s Microsoft-Build EventSource so FallbackAssemblyLoadStart/Stop (EventIds 97/98) actually emit their declared assemblyName payload to ETW/EventPipe, instead of dropping it due to calling WriteEvent without arguments.
Changes:
- Pass
assemblyNameintoWriteEvent(97, ...)forFallbackAssemblyLoadStart. - Pass
assemblyNameintoWriteEvent(98, ...)forFallbackAssemblyLoadStop.
Comment on lines
701
to
711
| [Event(97, Keywords = Keywords.All)] | ||
| public void FallbackAssemblyLoadStart(string assemblyName) | ||
| { | ||
| WriteEvent(97); | ||
| WriteEvent(97, assemblyName); | ||
| } | ||
|
|
||
| [Event(98, Keywords = Keywords.All)] | ||
| public void FallbackAssemblyLoadStop(string assemblyName) | ||
| { | ||
| WriteEvent(98); | ||
| WriteEvent(98, assemblyName); | ||
| } |
AR-May
commented
Jun 10, 2026
| @@ -701,13 +701,13 @@ public void OutOfProcNodeShutDownStop(string shutdownReason) | |||
| [Event(97, Keywords = Keywords.All)] | |||
Member
Author
There was a problem hiding this comment.
Version does not need bumping because we do not change the method signature, it is the writer that was out of sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
FallbackAssemblyLoadStartandFallbackAssemblyLoadStopevents declare anassemblyNameparameter but callWriteEventwithout it. The payload is dropped before reaching ETW, so every trace consumer sees an empty payload.Testing
Existing unit tests